Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions include/paimon/file_index/file_index_reader.h
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ class PAIMON_EXPORT FileIndexReader : public FunctionVisitor<std::shared_ptr<Fil
Result<std::shared_ptr<FileIndexResult>> VisitEndsWith(const Literal& suffix) override;

Result<std::shared_ptr<FileIndexResult>> VisitContains(const Literal& literal) override;

Result<std::shared_ptr<FileIndexResult>> VisitLike(const Literal& literal) override;
};

} // namespace paimon
3 changes: 3 additions & 0 deletions include/paimon/predicate/function_visitor.h
Original file line number Diff line number Diff line change
Expand Up @@ -71,5 +71,8 @@ class PAIMON_EXPORT FunctionVisitor {

/// Evaluates whether string values contain the given substring.
virtual Result<T> VisitContains(const Literal& literal) = 0;

/// Evaluates whether string values like the given string.
virtual Result<T> VisitLike(const Literal& literal) = 0;
};
} // namespace paimon
3 changes: 3 additions & 0 deletions src/paimon/common/file_index/empty/empty_file_index_reader.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ class EmptyFileIndexReader : public FileIndexReader {
Result<std::shared_ptr<FileIndexResult>> VisitContains(const Literal& literal) override {
return FileIndexResult::Skip();
}
Result<std::shared_ptr<FileIndexResult>> VisitLike(const Literal& literal) override {
return FileIndexResult::Skip();
}
Result<std::shared_ptr<FileIndexResult>> VisitLessThan(const Literal& literal) override {
return FileIndexResult::Skip();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ TEST(EmptyFileIndexReaderTest, TestSimple) {
ASSERT_FALSE(reader.VisitStartsWith(lit0).value()->IsRemain().value());
ASSERT_FALSE(reader.VisitEndsWith(lit0).value()->IsRemain().value());
ASSERT_FALSE(reader.VisitContains(lit0).value()->IsRemain().value());
ASSERT_FALSE(reader.VisitLike(lit0).value()->IsRemain().value());
ASSERT_FALSE(reader.VisitLessThan(lit0).value()->IsRemain().value());
ASSERT_FALSE(reader.VisitGreaterOrEqual(lit0).value()->IsRemain().value());
ASSERT_FALSE(reader.VisitLessOrEqual(lit0).value()->IsRemain().value());
Expand Down
4 changes: 4 additions & 0 deletions src/paimon/common/file_index/file_index_reader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ Result<std::shared_ptr<FileIndexResult>> FileIndexReader::VisitContains(const Li
return FileIndexResult::Remain();
}

Result<std::shared_ptr<FileIndexResult>> FileIndexReader::VisitLike(const Literal& literal) {
return FileIndexResult::Remain();
}

Result<std::shared_ptr<FileIndexResult>> FileIndexReader::VisitLessThan(const Literal& literal) {
return FileIndexResult::Remain();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,12 @@ class FileIndexReaderWrapper : public GlobalIndexReader {
return transform_(file_index_result);
}

Result<std::shared_ptr<GlobalIndexResult>> VisitLike(const Literal& literal) override {
PAIMON_ASSIGN_OR_RAISE(std::shared_ptr<FileIndexResult> file_index_result,
reader_->VisitLike(literal));
return transform_(file_index_result);
}

Result<std::shared_ptr<VectorSearchGlobalIndexResult>> VisitVectorSearch(
const std::shared_ptr<VectorSearch>& vector_search) override {
return Status::Invalid(
Expand Down
4 changes: 4 additions & 0 deletions src/paimon/global_index/lucene/lucene_global_index.h
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,10 @@ class LuceneGlobalIndexReader : public GlobalIndexReader {
return CreateAllResult();
}

Result<std::shared_ptr<GlobalIndexResult>> VisitLike(const Literal& literal) override {
return CreateAllResult();
}

Result<std::shared_ptr<VectorSearchGlobalIndexResult>> VisitVectorSearch(
const std::shared_ptr<VectorSearch>& vector_search) override {
return Status::Invalid(
Expand Down
4 changes: 4 additions & 0 deletions src/paimon/global_index/lumina/lumina_global_index.h
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,10 @@ class LuminaIndexReader : public GlobalIndexReader {
return BitmapGlobalIndexResult::FromRanges({Range(0, range_end_)});
}

Result<std::shared_ptr<GlobalIndexResult>> VisitLike(const Literal& literal) override {
return BitmapGlobalIndexResult::FromRanges({Range(0, range_end_)});
}

bool IsThreadSafe() const override {
return true;
}
Expand Down
Loading