fix(build): map missing *_shared deps to *_static in static-only builds#125
Merged
zjw1111 merged 4 commits intoFeb 12, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CMake helper used to define Paimon libraries so that dependency edges are preserved in static-only builds, even when dependencies are still referenced by their *_shared target names.
Changes:
- Map missing
*_shareddependency target names to*_staticwhen the shared target doesn’t exist. - Keep
add_dependencies()edges for the object library (${LIB_NAME}_objlib) by filtering/mapping dependencies to existing targets.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
In static-only mode, some dependency names are still declared as *_shared. If the shared target does not exist, dependency edges can be dropped, causing build-order issues.
Verification
-DPAIMON_BUILD_SHARED=OFF
-DPAIMON_BUILD_STATIC=ON
-DPAIMON_BUILD_TESTS=OFF
-DPAIMON_ENABLE_ORC=ON
(build finished successfully)