Skip to content

fix(build): map missing *_shared deps to *_static in static-only builds#125

Merged
zjw1111 merged 4 commits into
alibaba:mainfrom
xylaaaaa:fix/static-only-shared-dep-mapping
Feb 12, 2026
Merged

fix(build): map missing *_shared deps to *_static in static-only builds#125
zjw1111 merged 4 commits into
alibaba:mainfrom
xylaaaaa:fix/static-only-shared-dep-mapping

Conversation

@xylaaaaa

@xylaaaaa xylaaaaa commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • map *_shared dependency names to *_static when the shared target is unavailable in static-only builds
  • preserve add_dependencies edges for object libraries in static-only mode

Why

In static-only mode, some dependency names are still declared as *_shared. If the shared target does not exist, dependency edges can be dropped, causing build-order issues.

Verification

  • standalone static-only build passed:
    -DPAIMON_BUILD_SHARED=OFF
    -DPAIMON_BUILD_STATIC=ON
    -DPAIMON_BUILD_TESTS=OFF
    -DPAIMON_ENABLE_ORC=ON
    (build finished successfully)

Copilot AI review requested due to automatic review settings February 9, 2026 08:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CMake helper used to define Paimon libraries so that dependency edges are preserved in static-only builds, even when dependencies are still referenced by their *_shared target names.

Changes:

  • Map missing *_shared dependency target names to *_static when the shared target doesn’t exist.
  • Keep add_dependencies() edges for the object library (${LIB_NAME}_objlib) by filtering/mapping dependencies to existing targets.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cmake_modules/BuildUtils.cmake

@lucasfang lucasfang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zjw1111
zjw1111 merged commit 933fb35 into alibaba:main Feb 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants