Skip to content

fix(build): map missing *_shared deps to *_static in static-only builds #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zjw1111 merged 4 commits into from
Feb 12, 2026
Merged

fix(build): map missing *_shared deps to *_static in static-only builds #125

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3d285a
fix(build): map missing *_shared deps to *_static in static-only builds
xylaaaaa Feb 9, 2026
2e2110a
style(cmake): format BuildUtils dependency mapping for cmake-format
xylaaaaa Feb 9, 2026
32cdbbd
Merge branch 'main' into fix/static-only-shared-dep-mapping
lucasfang Feb 10, 2026
4b5972a
Merge branch 'main' into fix/static-only-shared-dep-mapping
lxy-9602 Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions cmake_modules/BuildUtils.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,19 @@ function(add_paimon_lib LIB_NAME)
# Necessary to make static linking into other shared libraries work properly
set_property(TARGET ${LIB_NAME}_objlib PROPERTY POSITION_INDEPENDENT_CODE 1)
if(ARG_DEPENDENCIES)
# Avoid add_dependencies on non-existent targets (e.g. when building static only).
# In static-only builds, some dependency names are still declared as
# *_shared. Map them to *_static when the shared target is unavailable.
set(_paimon_objlib_deps)
foreach(_paimon_dep IN LISTS ARG_DEPENDENCIES)
if(TARGET ${_paimon_dep})
list(APPEND _paimon_objlib_deps ${_paimon_dep})
set(_paimon_mapped_dep "${_paimon_dep}")
if(NOT TARGET ${_paimon_mapped_dep} AND _paimon_dep MATCHES "_shared$")
string(REGEX REPLACE "_shared$" "_static" _paimon_mapped_dep
"${_paimon_dep}")
endif()
if(TARGET ${_paimon_mapped_dep})
Comment thread
zjw1111 marked this conversation as resolved.
list(APPEND _paimon_objlib_deps ${_paimon_mapped_dep})
endif()
unset(_paimon_mapped_dep)
endforeach()
if(_paimon_objlib_deps)
add_dependencies(${LIB_NAME}_objlib ${_paimon_objlib_deps})
Expand Down
Loading