feat: add read-optimized system table#403
Merged
Merged
Conversation
gripleaf
force-pushed
the
feat/value_stats_filter
branch
3 times, most recently
from
July 8, 2026 09:41
7aa2715 to
1449d94
Compare
gripleaf
marked this pull request as ready for review
July 8, 2026 09:45
gripleaf
changed the title
gripleaf
force-pushed
the
feat/value_stats_filter
branch
from
July 9, 2026 06:33
1449d94 to
b125cf8
Compare
Collaborator
|
@suxiaogang223 Would you mind helping take a look when you have time, since you’re most familiar with system table. Thanks a lot! |
lxy-9602
reviewed
Jul 10, 2026
lxy-9602
reviewed
Jul 10, 2026
lszskye
reviewed
Jul 10, 2026
gripleaf
force-pushed
the
feat/value_stats_filter
branch
2 times, most recently
from
July 13, 2026 08:41
8a8f999 to
558f889
Compare
suxiaogang223
suggested changes
Jul 13, 2026
suxiaogang223
left a comment
suxiaogang223
left a comment
Contributor
There was a problem hiding this comment.
I found two additional issues that are not covered by the existing review threads.
gripleaf
force-pushed
the
feat/value_stats_filter
branch
from
July 13, 2026 12:08
558f889 to
5098767
Compare
Contributor
Author
|
@lxy-9602 @suxiaogang223 I have fixed the issues according to the comments. Please take some time to review again when you get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add support for the read-optimized
$rosystem table. For primary-key tables,$roreads only the highest LSM level produced by full compaction and skips merge-on-read across levels. Append-only tables keep the same read behavior as the base table, including streaming reads.This also refactors read-optimized scan configuration into
DataTableBatchScan, uses context builders for$roscan/read contexts, and documents freshness and value-stats filtering behavior.Tests
E2E test:
SystemTableTest.TestReadOptimizedSystemTableRegistrationSystemTableTest.TestReadOptimizedSystemTablePathParsingTableScanTest.TestReadOptimizedPrimaryKeyStreamingScanUnsupportedSystemTableReadInteTest.TestReadOptimizedSystemTableSystemTableReadInteTest.TestReadOptimizedAppendOnlySystemTableWithStreamingScanSystemTableReadInteTest.TestReadOptimizedSystemTableWithBranchSystemTableReadInteTest.TestReadOptimizedSystemTableWithFirstRowMergeEngineAPI and Format
No public API, storage format, or protocol changes.
Documentation
Added user guide documentation for system tables and the read-optimized $ro system table.
Generative AI tooling
Generated-by: OpenAI Codex GPT-5