fix(orc): avoid removed Arrow bitmap append API#423
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ORC-to-Arrow adapter implementation to remain compatible with newer Apache Arrow releases by removing usage of the deprecated/removed arrow::ArrayBuilder::AppendToBitmap API and replacing it with the supported Reserve + UnsafeAppendToBitmap sequence.
Changes:
- Replaced
arrow::ArrayBuilder::AppendToBitmap(valid_bytes, length)withReserve(length)+UnsafeAppendToBitmap(valid_bytes, length)in multiple unpooled builder implementations. - Kept the existing “no nulls” fast-path behavior (
IncreaseLength) unchanged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wgtmac
force-pushed
the
codex/fix-orc-arrow-bitmap-api
branch
from
July 15, 2026 05:52
39d5dd5 to
e3c38e4
Compare
lszskye
reviewed
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: N/A
Arrow removed
ArrayBuilder::AppendToBitmapin newer releases. Replace the ORC adapter's calls with the equivalentReserve+UnsafeAppendToBitmapsequence, which is available in the repository's pinned Arrow 17.0.0 and newer Arrow versions.API and Format
No public API, storage format, or protocol changes.
Documentation
No new feature; no documentation update required.
Generative AI tooling
Generated-by: OpenAI Codex