fix(btree): preserve empty keys in index metadata & disable global bitmap index#436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: apache/paimon#7811
SortedIndexFileMetaand distinguish empty serialized keys from null key boundaries.Previously, both an empty string key and a null boundary were encoded with a zero key length. Deserialization therefore treated an empty first key as null, which could cause incorrect file pruning or a null dereference when evaluating predicates.
This change:
null, an empty string, and a normal string and querying them with different predicates.bitmapglobal index type as unsupported. The legacy implementation remains in the codebase and is enabled only by an internal testing option until support for the new Java-compatible format is implemented.Tests
Added or updated coverage for:
API and Format
No public API under
include/is changed.The BTree index metadata format is extended from:
firstKeyLength + firstKey + lastKeyLength + lastKey + hasNullsto:
firstKeyLength + firstKey + lastKeyLength + lastKey + hasNulls + formatVersion + nullKeyFlagsThe new format matches Java
SortedIndexFileMeta. The reader remains backward compatible with legacy metadata that does not contain the two appended bytes.Bitmap global indexes are temporarily disabled by default. Requests for the
bitmapglobal index type are handled as an unknown index type. No bitmap implementation code is removed.Documentation
Generative AI tooling
Generated-by: OpenAI Codex (GPT-5)