fix: memory: fix Bytes move assignment ownership transfer#82
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the move-assignment implementation of paimon::Bytes to avoid a destructor + memcpy pattern that could lead to double-free or undefined behavior and instead performs an explicit, safe ownership transfer.
Changes:
- Replace
Bytes::operator=(Bytes&&)implementation fromthis->~Bytes(); memcpy; placement-newto explicit release of current buffer viapool_->Freefollowed by field-wise move ofpool_,data_, andsize_. - Clear the moved-from
Bytesobject by nullingpool_anddata_and zeroingsize_to make its destructor a no-op and avoid double-free.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lxy-9602
reviewed
Jan 27, 2026
xylaaaaa
force-pushed
the
fix-bytes-move-assign
branch
from
February 3, 2026 07:32
381cdff to
0df4771
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Fix the move assignment of
Bytesto avoid the~Bytes()+memcpypattern that can cause double-free/UB. The new implementation explicitly releases current memory, takes ownership fromother, and then nulls out the source.Tests
Not run.
API and Format
No API/storage/protocol changes (internal implementation only).
Documentation
No.