Skip to content

fix: remove redundant Python-side vector index type validation in create_index #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhourrr merged 3 commits into from
Apr 14, 2026
Merged

fix: remove redundant Python-side vector index type validation in create_index #297

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bf26ca
fix: correct vector index type check from to
songqing Apr 1, 2026
8b639ab
fix lint
songqing Apr 14, 2026
80d7a38
fix comment
songqing Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions python/zvec/model/collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,6 @@

__all__ = ["Collection"]

_VECTOR_INDEX_TYPES = (
HnswIndexParam,
HnswRabitqIndexParam,
IVFIndexParam,
FlatIndexParam,
)


class Collection:
"""Represents an opened collection in Zvec.
Expand Down Expand Up @@ -133,15 +126,7 @@ def create_index(
option (Optional[IndexOption], optional): Index creation options.
Defaults to ``IndexOption()``.

Raises:
ValueError: If a vector index is applied to a non-vector field.
"""
if index_param in _VECTOR_INDEX_TYPES and not self.schema.vector(field_name):
supported_types = ", ".join(cls.__name__ for cls in _VECTOR_INDEX_TYPES)
raise ValueError(
f"Cannot apply vector index to non-vector field '{field_name}'. "
f"The field must be of vector type to use index types like {supported_types}."
)
self._obj.CreateIndex(field_name, index_param, option)
self._schema = CollectionSchema._from_core(self._obj.Schema())

Expand Down
Loading