Open
Conversation
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new Rust SDK for the zvec vector database, including a safe, idiomatic Rust API, FFI bindings, benchmarking, and CI integration. The changes add a Cargo workspace with two crates (
zvecandzvec-sys), comprehensive documentation, coverage scripts, and GitHub Actions workflows for building and testing the Rust SDK on multiple platforms.Rust SDK Structure and Documentation:
zvec-sys(FFI bindings to the zvec C-API) andzvec(safe, high-level Rust wrapper). IncludesCargo.tomlfiles for both crates and workspace configuration. [1] [2] [3]README.mdfor the Rust SDK, covering architecture, build/test instructions, API usage, supported types, and index types.Testing, Benchmarking, and Coverage:
zvec/benches/zvec_bench.rsusing Criterion.rs, covering document creation, field access, insert, query, schema creation, and type conversions.scripts/coverage.shusingcargo-llvm-cov, supporting HTML, LCOV, text, and JSON reports.CI/CD Integration:
.github/workflows/01-ci-pipeline.yml) to add jobs for building and testing the Rust SDK on macOS ARM64 and Linux x64..github/workflows/06-rust-build.yml) for building, linting, testing, and benchmarking the Rust SDK, including C library build steps and environment setup.