More o2linter fixes

Author: Oussama3030

PWGLF/Tasks/Resonances/k892hadronphoton.cxx

@@ -60,12 +60,12 @@ using namespace o2::framework::expressions;
 using KStars = soa::Join<aod::KStarCores, aod::KStarPhotonExtras, aod::KShortExtras, aod::KStarCollRef>;
 using MCKStars = soa::Join<aod::KStarCores, aod::KStarPhotonExtras, aod::KShortExtras, aod::KStarMCCores, aod::KStarCollRef>;
 
-static const std::vector<std::string> PhotonSels = {"NoSel", "V0Type", "DCADauToPV",
+static const std::vector<std::string> photonSels = {"NoSel", "V0Type", "DCADauToPV",
                                                     "DCADau", "DauTPCCR", "TPCNSigmaEl", "V0pT",
                                                     "Y", "V0Radius", "RZCut", "Armenteros", "CosPA",
                                                     "PsiPair", "Phi", "Mass"};
 
-static const std::vector<std::string> KShortSels = {"NoSel", "V0Radius", "DCADau", "Armenteros",
+static const std::vector<std::string> kshortSels = {"NoSel", "V0Radius", "DCADau", "Armenteros",
                                                     "CosPA", "Y", "TPCCR", "DauITSCls", "Lifetime",
                                                     "TPCTOFPID", "DCADauToPV", "Mass"};
 
@@ -121,7 +121,7 @@ struct k892hadronphoton {
   } eventSelections;
 
   // generated
-  Configurable<bool> mc_keepOnlyFromGenerator{"mc_keepOnlyFromGenerator", true, "if true, consider only particles from generator to calculate efficiency."};
+  Configurable<bool> mcKeepOnlyFromGenerator{"mcKeepOnlyFromGenerator", true, "if true, consider only particles from generator to calculate efficiency."};
 
   // QA
   Configurable<bool> fillBkgQAhistos{"fillBkgQAhistos", false, "if true, fill MC QA histograms for Bkg study. Only works with MC."};
@@ -134,7 +134,7 @@ struct k892hadronphoton {
 
   //// K0Short criteria:
   struct : ConfigurableGroup {
-    Configurable<float> kshort_MLThreshold{"kshort_MLThreshold", 0.1, "Decision Threshold value to select kshorts"};
+    Configurable<float> kshortMLThreshold{"kshortMLThreshold", 0.1, "Decision Threshold value to select kshorts"};
     Configurable<float> kshortMinDCANegToPv{"kshortMinDCANegToPv", .05, "min DCA Neg To PV (cm)"};
     Configurable<float> kshortMinDCAPosToPv{"kshortMinDCAPosToPv", .05, "min DCA Pos To PV (cm)"};
     Configurable<float> kshortMaxDCAV0Dau{"kshortMaxDCAV0Dau", 2.5, "Max DCA V0 Daughters (cm)"};
@@ -162,7 +162,7 @@ struct k892hadronphoton {
 
   //// Photon criteria:
   struct : ConfigurableGroup {
-    Configurable<float> gamma_MLThreshold{"gamma_MLThreshold", 0.1, "Decision Threshold value to select gammas"};
+    Configurable<float> gammaMLThreshold{"gammaMLThreshold", 0.1, "Decision Threshold value to select gammas"};
     Configurable<int> photonv0TypeSel{"photonv0TypeSel", 7, "select on a certain V0 type (leave negative if no selection desired)"};
     Configurable<float> photonMinDCADauToPv{"photonMinDCADauToPv", 0.0, "Min DCA daughter To PV (cm)"};
     Configurable<float> photonMaxDCAV0Dau{"photonMaxDCAV0Dau", 3.5, "Max DCA V0 Daughters (cm)"};
@@ -408,16 +408,16 @@ struct k892hadronphoton {
       histos.add("Selection/Photon/hCandidateSel", "hCandidateSel", kTH1D, {axisCandSel});
       histos.add("Selection/KShort/hCandidateSel", "hCandidateSel", kTH1D, {axisCandSel});
 
-      for (size_t i = 0; i < PhotonSels.size(); ++i) {
-        const auto& sel = PhotonSels[i];
+      for (size_t i = 0; i < photonSels.size(); ++i) {
+        const auto& sel = photonSels[i];
 
         histos.add(Form("Selection/Photon/h2d%s", sel.c_str()), ("h2d" + sel).c_str(), kTH2D, {axisPt, axisPhotonMass});
         histos.get<TH1>(HIST("Selection/Photon/hCandidateSel"))->GetXaxis()->SetBinLabel(i + 1, sel.c_str());
         histos.add(Form("Selection/KStar/h2dPhoton%s", sel.c_str()), ("h2dPhoton" + sel).c_str(), kTH2D, {axisPt, axisKStarMass});
       }
 
-      for (size_t i = 0; i < KShortSels.size(); ++i) {
-        const auto& sel = KShortSels[i];
+      for (size_t i = 0; i < kshortSels.size(); ++i) {
+        const auto& sel = kshortSels[i];
 
         histos.add(Form("Selection/KShort/h2d%s", sel.c_str()), ("h2d" + sel).c_str(), kTH2D, {axisPt, axisKShortMass});
         histos.get<TH1>(HIST("Selection/KShort/hCandidateSel"))->GetXaxis()->SetBinLabel(i + 1, sel.c_str());
@@ -691,7 +691,7 @@ struct k892hadronphoton {
         continue;
 
       // Selection on the source (generator/transport)
-      if (!genParticle.producedByGenerator() && mc_keepOnlyFromGenerator)
+      if (!genParticle.producedByGenerator() && mcKeepOnlyFromGenerator)
         continue;
 
       // Select corresponding mc collision && Basic event selection
@@ -988,28 +988,28 @@ struct k892hadronphoton {
   void fillSelHistos(TKStarObject const& kstar, int PDGRequired)
   {
 
-    static constexpr std::string_view PhotonSelsLocal[] = {"NoSel", "V0Type", "DCADauToPV",
+    static constexpr std::string_view photonSelsLocal[] = {"NoSel", "V0Type", "DCADauToPV",
                                                            "DCADau", "DauTPCCR", "TPCNSigmaEl", "V0pT",
                                                            "Y", "V0Radius", "RZCut", "Armenteros", "CosPA",
                                                            "PsiPair", "Phi", "Mass"};
 
-    static constexpr std::string_view KShortSelsLocal[] = {"NoSel", "V0Radius", "DCADau", "Armenteros",
+    static constexpr std::string_view kshortSelsLocal[] = {"NoSel", "V0Radius", "DCADau", "Armenteros",
                                                            "CosPA", "Y", "TPCCR", "DauITSCls", "Lifetime",
                                                            "TPCTOFPID", "DCADauToPV", "Mass"};
 
     if (std::abs(PDGRequired) == PDG_t::kGamma) {
-      if constexpr (selection_index >= 0 && selection_index < static_cast<int>(std::size(PhotonSelsLocal))) {
+      if constexpr (selection_index >= 0 && selection_index < static_cast<int>(std::size(photonSelsLocal))) {
         histos.fill(HIST("Selection/Photon/hCandidateSel"), selection_index);
-        histos.fill(HIST("Selection/Photon/h2d") + HIST(PhotonSelsLocal[selection_index]), kstar.photonPt(), kstar.photonMass());
-        histos.fill(HIST("Selection/KStar/h2dPhoton") + HIST(PhotonSelsLocal[selection_index]), kstar.pt(), kstar.kstarMass());
+        histos.fill(HIST("Selection/Photon/h2d") + HIST(photonSelsLocal[selection_index]), kstar.photonPt(), kstar.photonMass());
+        histos.fill(HIST("Selection/KStar/h2dPhoton") + HIST(photonSelsLocal[selection_index]), kstar.pt(), kstar.kstarMass());
       }
     }
 
     if (std::abs(PDGRequired) == PDG_t::kK0Short) {
-      if constexpr (selection_index >= 0 && selection_index < static_cast<int>(std::size(KShortSelsLocal))) {
+      if constexpr (selection_index >= 0 && selection_index < static_cast<int>(std::size(kshortSelsLocal))) {
         histos.fill(HIST("Selection/KShort/hCandidateSel"), selection_index);
-        histos.fill(HIST("Selection/KShort/h2d") + HIST(KShortSelsLocal[selection_index]), kstar.kshortPt(), kstar.kshortMass());
-        histos.fill(HIST("Selection/KStar/h2dKShort") + HIST(KShortSelsLocal[selection_index]), kstar.pt(), kstar.kstarMass());
+        histos.fill(HIST("Selection/KShort/h2d") + HIST(kshortSelsLocal[selection_index]), kstar.kshortPt(), kstar.kshortMass());
+        histos.fill(HIST("Selection/KStar/h2dKShort") + HIST(kshortSelsLocal[selection_index]), kstar.pt(), kstar.kstarMass());
       }
     }
   }

PWGLF/Tasks/Resonances/k892hadronphotonBkg.cxx

@@ -20,14 +20,14 @@
 //    oussama.benchikhi@cern.ch
 //
 
-#include "PWGLF/DataModel/LFSigmaTables.h"
 #include "PWGLF/DataModel/LFStrangenessMLTables.h"
 #include "PWGLF/DataModel/LFStrangenessPIDTables.h"
 #include "PWGLF/DataModel/LFStrangenessTables.h"
 
 #include "Common/CCDB/EventSelectionParams.h"
 #include "Common/CCDB/ctpRateFetcher.h"
 #include "Common/Core/RecoDecay.h"
+#include "Common/DataModel/Centrality.h"
 
 #include <CCDB/BasicCCDBManager.h>
 #include <CommonConstants/MathConstants.h>
@@ -42,18 +42,18 @@
 #include <Framework/InitContext.h>
 #include <Framework/OutputObjHeader.h>
 #include <Framework/runDataProcessing.h>
+#include "Framework/BinningPolicy.h" 
 
-#include <Math/Vector3D.h>
 #include <Math/Vector4D.h>
 #include <TH1.h>
-#include <TMath.h>
 #include <TRandom3.h>
 
 #include <array>
 #include <cmath>
 #include <cstdint>
 #include <string>
 #include <vector>
+#include <cstddef>
 
 using namespace o2;
 using namespace o2::framework;
@@ -127,7 +127,7 @@ struct k892hadronphotonBkg {
   //// Photon criteria:
   struct : ConfigurableGroup {
     std::string prefix = "photonSelections"; // JSON group name
-    Configurable<float> gamma_MLThreshold{"gamma_MLThreshold", 0.1, "Decision Threshold value to select gammas"};
+    Configurable<float> gammaMLThreshold{"gammaMLThreshold", 0.1, "Decision Threshold value to select gammas"};
     Configurable<int> photonv0TypeSel{"photonv0TypeSel", 7, "select on a certain V0 type (leave negative if no selection desired)"};
     Configurable<float> photonMinDCADauToPv{"photonMinDCADauToPv", 0.0, "Min DCA daughter To PV (cm)"};
     Configurable<float> photonMaxDCAV0Dau{"photonMaxDCAV0Dau", 3.5, "Max DCA V0 Daughters (cm)"};
@@ -155,7 +155,7 @@ struct k892hadronphotonBkg {
   // KShort criteria:
   struct : ConfigurableGroup {
     std::string prefix = "kshortSelections"; // JSON group name
-    Configurable<float> kshort_MLThreshold{"kshort_MLThreshold", 0.1, "Decision Threshold value to select kshorts"};
+    Configurable<float> kshortMLThreshold{"kshortMLThreshold", 0.1, "Decision Threshold value to select kshorts"};
     Configurable<float> kshortMinDCANegToPv{"kshortMinDCANegToPv", .05, "min DCA Neg To PV (cm)"};
     Configurable<float> kshortMinDCAPosToPv{"kshortMinDCAPosToPv", .05, "min DCA Pos To PV (cm)"};
     Configurable<float> kshortMaxDCAV0Dau{"kshortMaxDCAV0Dau", 2.5, "Max DCA V0 Daughters (cm)"};
@@ -249,7 +249,7 @@ struct k892hadronphotonBkg {
   //_______________________________________________
   // Event selection (identical to the builder)
   template <typename TCollision>
-  bool IsEventAccepted(TCollision const& collision, bool fillHists)
+  bool isEventAccepted(TCollision const& collision, bool fillHists)
   {
     if (fillHists)
       histos.fill(HIST("hEventSelection"), 0. /* all collisions */);
@@ -393,10 +393,10 @@ struct k892hadronphotonBkg {
     if (gamma.v0Type() != photonSelections.photonv0TypeSel && photonSelections.photonv0TypeSel > -1)
       return false;
 
-    float PhotonY = RecoDecay::y(std::array{gamma.px(), gamma.py(), gamma.pz()}, o2::constants::physics::MassGamma);
+    float photonY = RecoDecay::y(std::array{gamma.px(), gamma.py(), gamma.pz()}, o2::constants::physics::MassGamma);
 
     if (useMLScores) {
-      if (gamma.gammaBDTScore() <= photonSelections.gamma_MLThreshold)
+      if (gamma.gammaBDTScore() <= photonSelections.gammaMLThreshold)
         return false;
 
     } else {
@@ -405,7 +405,7 @@ struct k892hadronphotonBkg {
       if ((gamma.mGamma() < 0) || (gamma.mGamma() > photonSelections.photonMaxMass))
         return false;
 
-      if ((PhotonY < photonSelections.photonMinRapidity) || (PhotonY > photonSelections.photonMaxRapidity))
+      if ((photonY < photonSelections.photonMinRapidity) || (photonY > photonSelections.photonMaxRapidity))
         return false;
 
       if (gamma.negativeeta() < photonSelections.photonDauEtaMin || gamma.negativeeta() > photonSelections.photonDauEtaMax)
@@ -429,8 +429,8 @@ struct k892hadronphotonBkg {
       if (gamma.v0cosPA() < photonSelections.photonMinV0cospa)
         return false;
 
-      float PhotonPhi = RecoDecay::phi(gamma.px(), gamma.py());
-      if ((((PhotonPhi > photonSelections.photonPhiMin1) && (PhotonPhi < photonSelections.photonPhiMax1)) || ((PhotonPhi > photonSelections.photonPhiMin2) && (PhotonPhi < photonSelections.photonPhiMax2))) && ((photonSelections.photonPhiMin1 != -1) && (photonSelections.photonPhiMax1 != -1) && (photonSelections.photonPhiMin2 != -1) && (photonSelections.photonPhiMax2 != -1)))
+      float photonPhi = RecoDecay::phi(gamma.px(), gamma.py());
+      if ((((photonPhi > photonSelections.photonPhiMin1) && (photonPhi < photonSelections.photonPhiMax1)) || ((photonPhi > photonSelections.photonPhiMin2) && (photonPhi < photonSelections.photonPhiMax2))) && ((photonSelections.photonPhiMin1 != -1) && (photonSelections.photonPhiMax1 != -1) && (photonSelections.photonPhiMin2 != -1) && (photonSelections.photonPhiMax2 != -1)))
         return false;
 
       if (gamma.qtarm() > photonSelections.photonMaxQt)
@@ -465,7 +465,7 @@ struct k892hadronphotonBkg {
       return false;
 
     if (useMLScores) {
-      // if (kshort.k0ShortBDTScore() <= kshortSelections.KShort_MLThreshold)
+      // if (kshort.k0ShortBDTScore() <= kshortSelections.kshortMLThreshold)
       return false;
 
     } else {
@@ -600,7 +600,7 @@ struct k892hadronphotonBkg {
     // ── Pass 1: populate pools using single-particle selections ──
     for (const auto& coll : collisions) {
 
-      if (eventSelections.fUseEventSelection && !IsEventAccepted(coll, true))
+      if (eventSelections.fUseEventSelection && !isEventAccepted(coll, true))
         continue;
 
       for (size_t i = 0; i < v0grouped[coll.globalIndex()].size(); i++) {
@@ -654,7 +654,7 @@ struct k892hadronphotonBkg {
         for (int kIdx : kshorts1) {
           auto kshort = fullV0s.rawIteratorAt(kIdx);
           float kP = std::hypot(kshort.px(), kshort.py(), kshort.pz());
-          ROOT::Math::PxPyPzEVector FourMomKShort(
+          ROOT::Math::PxPyPzEVector fourMomKShort(
             kshort.px(), kshort.py(), kshort.pz(),
             std::sqrt(kP * kP +
                       o2::constants::physics::MassK0Short *
@@ -663,23 +663,23 @@ struct k892hadronphotonBkg {
           for (int pIdx : photons2) {
             auto photon = fullV0s.rawIteratorAt(pIdx);
             float pP = std::hypot(photon.px(), photon.py(), photon.pz());
-            ROOT::Math::PxPyPzEVector FourMomPhoton(
+            ROOT::Math::PxPyPzEVector fourMomPhoton(
               photon.px(), photon.py(), photon.pz(), pP);
 
-            auto FourMomKStar = FourMomPhoton + FourMomKShort;
+            auto fourMomKStar = fourMomPhoton + fourMomKShort;
 
-            double cosOA = FourMomPhoton.Vect().Dot(FourMomKShort.Vect()) /
-                           (FourMomPhoton.P() * FourMomKShort.P());
+            double cosOA = fourMomPhoton.Vect().Dot(fourMomKShort.Vect()) /
+                           (fourMomPhoton.P() * fourMomKShort.P());
             double openAngle = std::acos(cosOA);
-            float mass = FourMomKStar.M();
-            float pt = FourMomKStar.Pt();
+            float mass = fourMomKStar.M();
+            float pt = fourMomKStar.Pt();
             // Rapidity computed under the K*(892) mass hypothesis (NOT the actual pair
             // invariant mass) to match the same-event rotational background and the
             // buildKStar signal selection, so the rapidity acceptance is identical for
             // signal and all backgrounds.
-            float rapidity = RecoDecay::y(std::array{static_cast<float>(FourMomKStar.Px()),
-                                                     static_cast<float>(FourMomKStar.Py()),
-                                                     static_cast<float>(FourMomKStar.Pz())},
+            float rapidity = RecoDecay::y(std::array{static_cast<float>(fourMomKStar.Px()),
+                                                     static_cast<float>(fourMomKStar.Py()),
+                                                     static_cast<float>(fourMomKStar.Pz())},
                                           o2::constants::physics::MassK0Star892);
 
             if (openAngle > kstarBkgConfig.kstarMaxOPAngle)
@@ -701,32 +701,32 @@ struct k892hadronphotonBkg {
         for (int pIdx : photons1) {
           auto photon = fullV0s.rawIteratorAt(pIdx);
           float pP = std::hypot(photon.px(), photon.py(), photon.pz());
-          ROOT::Math::PxPyPzEVector FourMomPhoton(
+          ROOT::Math::PxPyPzEVector fourMomPhoton(
             photon.px(), photon.py(), photon.pz(), pP);
 
           for (int kIdx : kshorts2) {
             auto kshort = fullV0s.rawIteratorAt(kIdx);
             float kP = std::hypot(kshort.px(), kshort.py(), kshort.pz());
-            ROOT::Math::PxPyPzEVector FourMomKShort(
+            ROOT::Math::PxPyPzEVector fourMomKShort(
               kshort.px(), kshort.py(), kshort.pz(),
               std::sqrt(kP * kP +
                         o2::constants::physics::MassK0Short *
                           o2::constants::physics::MassK0Short));
 
-            auto FourMomKStar = FourMomPhoton + FourMomKShort;
+            auto fourMomKStar = fourMomPhoton + fourMomKShort;
 
-            double cosOA = FourMomPhoton.Vect().Dot(FourMomKShort.Vect()) /
-                           (FourMomPhoton.P() * FourMomKShort.P());
+            double cosOA = fourMomPhoton.Vect().Dot(fourMomKShort.Vect()) /
+                           (fourMomPhoton.P() * fourMomKShort.P());
             double openAngle = std::acos(cosOA);
-            float mass = FourMomKStar.M();
-            float pt = FourMomKStar.Pt();
+            float mass = fourMomKStar.M();
+            float pt = fourMomKStar.Pt();
             // Rapidity computed under the K*(892) mass hypothesis (NOT the actual pair
             // invariant mass) to match the same-event rotational background and the
             // buildKStar signal selection, so the rapidity acceptance is identical for
             // signal and all backgrounds.
-            float rapidity = RecoDecay::y(std::array{static_cast<float>(FourMomKStar.Px()),
-                                                     static_cast<float>(FourMomKStar.Py()),
-                                                     static_cast<float>(FourMomKStar.Pz())},
+            float rapidity = RecoDecay::y(std::array{static_cast<float>(fourMomKStar.Px()),
+                                                     static_cast<float>(fourMomKStar.Py()),
+                                                     static_cast<float>(fourMomKStar.Pz())},
                                           o2::constants::physics::MassK0Star892);
 
             if (openAngle > kstarBkgConfig.kstarMaxOPAngle)

iwyu.out

@@ -0,0 +1 @@
+iwyu_tool.py: command not found