Fixed: Use constant references for non-modified iterators in range-based for loops.

Author: Oussama3030

PWGLF/Tasks/Resonances/k892hadronphoton.cxx

@@ -683,7 +683,7 @@ struct k892hadronphoton {
     fillGeneratedEventProperties(mcCollisions, collisions);
     std::vector<int> listBestCollisionIdx = getListOfRecoCollIndices(mcCollisions, collisions);
 
-    for (auto& genParticle : genParticles) {
+    for (const auto& genParticle : genParticles) {
       float centrality = 100.5f;
 
       // Has MC collision
@@ -802,35 +802,35 @@ struct k892hadronphoton {
     static constexpr std::string_view MainDir[] = {"BeforeSel", "AfterSel"};
 
     bool fIsKStar = kstar.isKStar();
-    int PhotonPDGCode = kstar.photonPDGCode();
-    int PhotonPDGCodeMother = kstar.photonPDGCodeMother();
-    int KShortPDGCode = kstar.kshortPDGCode();
-    int KShortPDGCodeMother = kstar.kshortPDGCodeMother();
+    int photonPDGCode = kstar.photonPDGCode();
+    int photonPDGCodeMother = kstar.photonPDGCodeMother();
+    int kshortPDGCode = kstar.kshortPDGCode();
+    int kshortPDGCodeMother = kstar.kshortPDGCodeMother();
     float kstarpT = kstar.pt();
     float kstarMass = kstar.kstarMass();
 
     histos.fill(HIST(MainDir[mode]) + HIST("/MC/BkgStudy/h2dPtVsMassKStar_All"), kstarpT, kstarMass);
 
     //_______________________________________
     // Real Gamma x Real KShort - but not from the same kstar!
-    if ((!fIsKStar)) { //(std::abs(PhotonPDGCode) == PDG_t::kGamma) && (std::abs(KShortPDGCode) == PDG_t::kK0Short) &&
+    if ((!fIsKStar)) { //(std::abs(photonPDGCode) == PDG_t::kGamma) && (std::abs(KShortPDGCode) == PDG_t::kK0Short) &&
       histos.fill(HIST(MainDir[mode]) + HIST("/MC/BkgStudy/h2dPtVsMassKStar_TrueDaughters"), kstarpT, kstarMass);
-      histos.fill(HIST(MainDir[mode]) + HIST("/MC/BkgStudy/h2dTrueDaughtersMatrix"), KShortPDGCodeMother, PhotonPDGCodeMother);
+      histos.fill(HIST(MainDir[mode]) + HIST("/MC/BkgStudy/h2dTrueDaughtersMatrix"), kshortPDGCodeMother, photonPDGCodeMother);
     }
 
     //_______________________________________
     // Real Gamma x fake KShort
-    if ((std::abs(PhotonPDGCode) == PDG_t::kGamma) && (std::abs(KShortPDGCode) != PDG_t::kK0Short))
+    if ((std::abs(photonPDGCode) == PDG_t::kGamma) && (std::abs(kshortPDGCode) != PDG_t::kK0Short))
       histos.fill(HIST(MainDir[mode]) + HIST("/MC/BkgStudy/h2dPtVsMassKStar_TrueGammaFakeKShort"), kstarpT, kstarMass);
 
     //_______________________________________
     // Fake Gamma x Real KShort
-    if ((std::abs(PhotonPDGCode) != PDG_t::kGamma) && ((std::abs(KShortPDGCode) == PDG_t::kK0Short)))
+    if ((std::abs(photonPDGCode) != PDG_t::kGamma) && ((std::abs(kshortPDGCode) == PDG_t::kK0Short)))
       histos.fill(HIST(MainDir[mode]) + HIST("/MC/BkgStudy/h2dPtVsMassKStar_FakeGammaTrueKShort"), kstarpT, kstarMass);
 
     //_______________________________________
     // Fake Gamma x Fake KShort
-    if ((std::abs(PhotonPDGCode) != PDG_t::kGamma) && (std::abs(KShortPDGCode) != PDG_t::kK0Short))
+    if ((std::abs(photonPDGCode) != PDG_t::kGamma) && (std::abs(kshortPDGCode) != PDG_t::kK0Short))
       histos.fill(HIST(MainDir[mode]) + HIST("/MC/BkgStudy/h2dPtVsMassKStar_FakeDaughters"), kstarpT, kstarMass);
   }
 

PWGLF/Tasks/Resonances/k892hadronphotonBkg.cxx

@@ -534,11 +534,11 @@ struct k892hadronphotonBkg {
       return;
 
     const float centrality = doPPAnalysis ? coll.centFT0M() : coll.centFT0C();
-    for (int kIdx : kshortIndices) {
-      auto kshort = fullV0s.rawIteratorAt(kIdx);
+    for (const int& kIdx : kshortIndices) {
+      const auto& kshort = fullV0s.rawIteratorAt(kIdx);
 
-      for (int pIdx : photonIndices) {
-        auto photon = fullV0s.rawIteratorAt(pIdx);
+      for (const int& pIdx : photonIndices) {
+        const auto& photon = fullV0s.rawIteratorAt(pIdx);
 
         // photon as a massless 4-vector
         ROOT::Math::PtEtaPhiMVector pGamma(photon.pt(),
@@ -631,7 +631,7 @@ struct k892hadronphotonBkg {
     // the framework applies JSON overrides), silently ignoring user configuration.
     BkgBinningType bkgColBinning{{axisVertexMixBkg, axisCentralityMixBkg}, true};
 
-    for (auto& [coll1, coll2] : selfCombinations(bkgColBinning, kstarBkgConfig.nMix, -1,
+    for (const auto& [coll1, coll2] : selfCombinations(bkgColBinning, kstarBkgConfig.nMix, -1,
                                                  collisions, collisions)) {
       if (coll1.globalIndex() == coll2.globalIndex())
         continue;
@@ -651,17 +651,17 @@ struct k892hadronphotonBkg {
 
       // K0s(coll1) × γ(coll2)
       if (!kshorts1.empty() && !photons2.empty()) {
-        for (int kIdx : kshorts1) {
-          auto kshort = fullV0s.rawIteratorAt(kIdx);
+        for (const int& kIdx : kshorts1) {
+          const auto& kshort = fullV0s.rawIteratorAt(kIdx);
           float kP = std::hypot(kshort.px(), kshort.py(), kshort.pz());
           ROOT::Math::PxPyPzEVector fourMomKShort(
             kshort.px(), kshort.py(), kshort.pz(),
             std::sqrt(kP * kP +
                       o2::constants::physics::MassK0Short *
                         o2::constants::physics::MassK0Short));
 
-          for (int pIdx : photons2) {
-            auto photon = fullV0s.rawIteratorAt(pIdx);
+          for (const int& pIdx : photons2) {
+            const auto& photon = fullV0s.rawIteratorAt(pIdx);
             float pP = std::hypot(photon.px(), photon.py(), photon.pz());
             ROOT::Math::PxPyPzEVector fourMomPhoton(
               photon.px(), photon.py(), photon.pz(), pP);
@@ -698,14 +698,14 @@ struct k892hadronphotonBkg {
 
       // γ(coll1) × K0s(coll2)
       if (!photons1.empty() && !kshorts2.empty()) {
-        for (int pIdx : photons1) {
-          auto photon = fullV0s.rawIteratorAt(pIdx);
+        for (const int pIdx : photons1) {
+          const auto& photon = fullV0s.rawIteratorAt(pIdx);
           float pP = std::hypot(photon.px(), photon.py(), photon.pz());
           ROOT::Math::PxPyPzEVector fourMomPhoton(
             photon.px(), photon.py(), photon.pz(), pP);
 
-          for (int kIdx : kshorts2) {
-            auto kshort = fullV0s.rawIteratorAt(kIdx);
+          for (const int kIdx : kshorts2) {
+            const auto& kshort = fullV0s.rawIteratorAt(kIdx);
             float kP = std::hypot(kshort.px(), kshort.py(), kshort.pz());
             ROOT::Math::PxPyPzEVector fourMomKShort(
               kshort.px(), kshort.py(), kshort.pz(),