[graph] Add possibility to set a specific cacheDir in the mg scene#3077
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3077 +/- ##
===========================================
- Coverage 83.98% 83.93% -0.06%
===========================================
Files 83 83
Lines 10829 10910 +81
===========================================
+ Hits 9095 9157 +62
- Misses 1734 1753 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b1c1131 to
036dcba
Compare
|
036dcba to
e1e8730
Compare
There was a problem hiding this comment.
It'd be nice to add some tests on the serialization/deserialization of graphs with a specific cache directory to ensure we're covering all cases.
The test that's currently part of the PR only checks that the setExplicitCacheDir works as expected.
Otherwise, it all looks good to me!
e1e8730 to
63bb2e7
Compare
3bc7b49 to
37ba04a
Compare
|
I added another system following @fcastan recommendations : |
b091df8 to
22e7b4e
Compare
e7b97a5 to
2a75c68
Compare
…oth relative and absolute paths. Handle serialization.
2a75c68 to
f78e7e0
Compare





Description
Add possibility to set a specific cache folder in the mg scene
meshroom_batcha new option enables saving the scene with a specific cache folder._explicitCacheDirparameter in theGraphtracks the explicit path we set (can be absolute or relative)About the Meshroom file :
graphIO: aCacheDirkey was added to the serialized format. Serialization is designed to save the cacheDir inside the.mgfilegraph: the deserialization is designed to load the explicit cache folder if we get one, and if we don't to select the default path (./MeshroomCache)We can see the custom cache directory on the status bar :

Tests
Here is a command that can be used to set a new cache directory in a meshroom file
The following steps can test this feature :
MeshroomCache)