Restructure template for easier developer onboarding#34
Restructure template for easier developer onboarding#34dominicaligent wants to merge 5 commits intomainfrom
Conversation
dominicaligent
force-pushed
the
feat/template-improvements
branch
4 times, most recently
from
f532ed9 to
b5ee582
Compare
dominicaligent
requested review from
Zigr1,
aligent-lturner,
harshaaligent,
hellboy1975,
nathaniel-cruz-aligent and
quangdo-aligent
dominicaligent
force-pushed
the
feat/template-improvements
branch
2 times, most recently
from
1d15d03 to
d6e4da7
Compare
aligent-lturner
left a comment
aligent-lturner
left a comment
There was a problem hiding this comment.
@dominicaligent I would agree that this is closer to what most apps will look like. But I'm wondering if we're going about this the wrong way.
Rather than having a single template with instructions to add this, remove that, change this file, etc. I think something like using an nx generator (we're already using nx for the monorepo) to scaffold a new app would be "nicer" for devs. Answer a few questions about what you need in the app, and have it all done without the manual steps.
Akin to what happens now with npx @adobe/aio-commerce-lib-app init
There was a problem hiding this comment.
I don't agree with renaming this. New Relic is not the only option here - it's used as the example implementation.
There was a problem hiding this comment.
Reverted the change. My change aimed for single responsibility, but I agree that the change will generate multiple files. Developers can decide on that.
There was a problem hiding this comment.
This file is still needed though, even if we don't have the sample actions.
There was a problem hiding this comment.
Added with basic details
There was a problem hiding this comment.
I would move this and useLazyAppBuilderAction to the equivalent directory under commerce-backend-ui-1
There was a problem hiding this comment.
Done. added some example in MainPage.tsx
Remove sample actions from the deployable codebase and save them as reference documentation in docs/examples/ so developers can copy what they need without shipping demo code in production. Replace the standalone frontend (src/web) with a Commerce Admin panel extension (commerce-backend-ui-1) that includes IMS authentication, Experience Cloud Shell integration, and a minimal starter page. Add a pre-build hook that automatically creates webpack configs for commerce extensions with auto-generated code, so developers do not need to set up webpack manually after running aio generate. Other changes: - Add .env.sample with all available environment variables - Make the telemetry service name configurable via environment variable - Rename telemetry config to newrelic-otel-config for clarity - Update all dependencies to their latest stable versions - Remove unused packages (cloudevents, uuid, ts-loader) - Consolidate shared TypeScript settings into the base config - Set minimum Node version to 22 to match the runtime target - Update README with current architecture and setup instructions
dominicaligent
force-pushed
the
feat/template-improvements
branch
from
d6e4da7 to
e1a3974
Compare
There was a problem hiding this comment.
Filename typo — app.config.yaml.extentions should be extensions
| <meta name="viewport" content="width=device-width, initial-scale=1.0, shrink-to-fit=no" /> | ||
| <meta name="theme-color" content="#333333" /> | ||
| <meta http-equiv="X-UA-Compatible" content="ie=edge" /> | ||
| <title>Product Labels</title> |
There was a problem hiding this comment.
Hardcoded 'Product Labels' title in HTML doesn't match extension ID 'sample'
must be left over from your product labels app
| @@ -0,0 +1,9 @@ | |||
|
|
|||
This reverts commit e378d17.
4 participants
Description
Remove sample actions from the deployable codebase and save them as
reference documentation in docs/examples/ so developers can copy what
they need without shipping demo code in production.
Replace the standalone frontend (src/web) with a Commerce Admin panel
extension (commerce-backend-ui-1) that includes IMS authentication,
Experience Cloud Shell integration, and a minimal starter page.
Add a pre-build hook that automatically creates webpack configs for
commerce extensions with auto-generated code, so developers do not
need to set up webpack manually after running aio generate.
Other changes: