Merge pull request #136 from aligent/fix/134-errant-delete-method

Fix/134 errant delete method

Author: jswift

src/BigCommerce/BaseApiClient.php

@@ -94,4 +94,9 @@ public function printDebugLastRequest()
     }
 
     abstract protected function defaultBaseUrl(): string;
+
+    public function getDebugContainer(): array
+    {
+        return $this->debugContainer;
+    }
 }

tests/BigCommerce/Api/Catalog/Products/VariantsApiTest.php

@@ -25,6 +25,17 @@ public function testCanGetProductVariant(): void
         $variantResponse = $this->getApi()->catalog()->product($productId)->variant($variantId)->get();
         $this->assertEquals($productId, $variantResponse->getProductVariant()->product_id);
         $this->assertEquals($variantId, $variantResponse->getProductVariant()->id);
+
+        $this->assertEquals("catalog/products/$productId/variants/$variantId", $this->getLastRequestPath());
+        $this->assertEquals('GET', $this->getLastRequest()->getMethod());
+
+        $methods = array_map(function ($r) {
+            return $r['request']->getMethod();
+        }, $this->getRequestHistory());
+
+        $this->assertNotContains('DELETE', $methods);
+        $this->assertNotContains('PUT', $methods);
+        $this->assertNotContains('POST', $methods);
     }
 
     public function testCanGetAllProductVariants(): void
@@ -36,4 +47,17 @@ public function testCanGetAllProductVariants(): void
         $this->assertEquals(3, $variantsResponse->getPagination()->total);
         $this->assertCount(3, $variantsResponse->getProductVariants());
     }
+
+    public function testCanDeleteProductVariant(): void
+    {
+        $this->setReturnData(self::EMPTY_RESPONSE, 204);
+
+        $productId = 192;
+        $variantId = 384;
+
+        $this->getApi()->catalog()->product($productId)->variant($variantId)->delete();
+
+        $this->assertEquals("catalog/products/$productId/variants/$variantId", $this->getLastRequestPath());
+        $this->assertEquals('DELETE', $this->getLastRequest()->getMethod());
+    }
 }

tests/BigCommerce/BigCommerceApiTest.php

@@ -63,9 +63,9 @@ public function getRequestHistory(): array
         return $this->container;
     }
 
-    public function getLastRequest(): Request
+    public function getLastRequest(): ?Request
     {
-        return end($this->container)['request'];
+        return empty($this->container) ? null : end($this->container)['request'];
     }
 
     public function getLastRequestPath(): string