Merge pull request #137 from aligent/fix/135-missing-config-values

Fix/135 missing config values

Author: jswift

src/BigCommerce/ResourceModels/Catalog/Product/ProductModifier.php

@@ -30,11 +30,7 @@ public function __construct(?stdClass $optionObject = null)
             !is_null($optionObject) && !empty($optionObject->config)
             && get_class($optionObject->config) !== ProductModifierConfig::class
         ) {
-            $this->config = new ProductModifierConfig(
-                $optionObject->config->product_list_adjusts_inventory,
-                $optionObject->config->product_list_adjusts_pricing,
-                $optionObject->config->product_list_shipping_calc
-            );
+            $this->config = new ProductModifierConfig($optionObject->config);
         }
 
         if (!is_null($optionObject) && isset($optionObject->config)) {

src/BigCommerce/ResourceModels/Catalog/Product/ProductModifierConfig.php

@@ -2,21 +2,41 @@
 
 namespace BigCommerce\ApiV3\ResourceModels\Catalog\Product;
 
-class ProductModifierConfig
+use BigCommerce\ApiV3\ResourceModels\ResourceModel;
+
+class ProductModifierConfig extends ResourceModel
 {
-    public const PRODUCT_LIST_SHIPPING_BY_WEIGHT = 'weight';
-
-    public bool $product_list_adjusts_inventory;
-    public bool $product_list_adjusts_pricing;
-    public string $product_list_shipping_calc;
-
-    public function __construct(
-        bool $product_list_adjusts_inventory,
-        bool $product_list_adjusts_pricing,
-        string $product_list_shipping_calc
-    ) {
-        $this->product_list_adjusts_inventory = $product_list_adjusts_inventory;
-        $this->product_list_adjusts_pricing = $product_list_adjusts_pricing;
-        $this->product_list_shipping_calc = $product_list_shipping_calc;
-    }
+    public const PRODUCT_LIST_SHIPPING_NONE       = 'none';
+    public const PRODUCT_LIST_SHIPPING_BY_WEIGHT  = 'weight';
+    public const PRODUCT_LIST_SHIPPING_BY_PACKAGE = 'package';
+
+    public ?string $default_value;
+    public ?bool $checked_by_default;
+    public ?string $checkbox_label;
+
+    public ?bool $date_limited;
+    public ?string $date_limit_mode;
+    public ?string $date_earliest_value;
+    public ?string $date_latest_value;
+
+    public ?string $file_types_mode;
+    public ?array $file_types_supported;
+    public ?array $file_types_other;
+    public ?int $file_max_size;
+
+    public ?bool $text_characters_limited;
+    public ?int $text_min_length;
+    public ?int $text_max_length;
+    public ?bool $text_lines_limited;
+    public ?int $text_max_lines;
+
+    public ?bool $number_limited;
+    public ?string $number_limit_mode;
+    public ?float $number_lowest_value;
+    public ?float $number_highest_value;
+    public ?bool $number_integers_only;
+
+    public ?bool $product_list_adjusts_inventory;
+    public ?bool $product_list_adjusts_pricing;
+    public ?string $product_list_shipping_calc;
 }

tests/BigCommerce/Api/Catalog/Products/ModifiersApiTest.php

@@ -2,6 +2,7 @@
 
 namespace BigCommerce\Tests\Api\Catalog\Products;
 
+use BigCommerce\ApiV3\ResourceModels\Catalog\Product\ProductModifierConfig;
 use BigCommerce\Tests\BigCommerceApiTest;
 
 class ModifiersApiTest extends BigCommerceApiTest
@@ -18,6 +19,56 @@ public function testCanGetModifier(): void
 
     public function testCanGetAllModifiers(): void
     {
-        $this->markTestIncomplete();
+        $this->setReturnData('catalog__products__modifiers__6962__values__get_all.json');
+
+        $modifiers = $this->getApi()->catalog()->product(6962)->modifiers()->getAll()->getProductModifiers();
+
+        $this->assertCount(8, $modifiers);
+        $this->assertEquals('earliest', $modifiers[5]->config->date_limit_mode);
+        $this->assertEquals(['images'], $modifiers[6]->config->file_types_supported);
+        $this->assertEquals(20, $modifiers[7]->config->text_max_lines);
+    }
+
+    public function testCanUpdateModifierConfigs(): void
+    {
+        $textConfig = new ProductModifierConfig((object)[
+            "default_value"   => "",
+            "text_characters_limited" => false,
+            "text_min_length" => 0,
+            "text_max_length" => 0
+        ]);
+
+        $dateConfig =  new ProductModifierConfig((object)[
+            "date_limited"      => false,
+            "date_limit_mode"   => "earliest",
+            "date_earliest_value" => null,
+            "date_latest_value" => null,
+            "default_value"     => "2022-06-01T00:00:00+00:00"
+        ]);
+
+        $fileConfig =  new ProductModifierConfig((object)[
+            "file_types_mode" => "specific",
+            "file_types_supported" => [
+                "images"
+            ],
+            "file_types_other" => [],
+            "file_max_size" => 524288
+        ]);
+
+        $this->assertEquals(
+            '{"default_value":"","text_characters_limited":false,"text_min_length":0,"text_max_length":0}',
+            json_encode($textConfig)
+        );
+
+        $this->assertEquals(
+            '{"default_value":"2022-06-01T00:00:00+00:00","date_limited":false,"date_limit_mode":"earliest"}',
+            json_encode($dateConfig)
+        );
+
+        $this->assertEquals(
+            '{"file_types_mode":"specific","file_types_supported":["images"],' .
+            '"file_types_other":[],"file_max_size":524288}',
+            json_encode($fileConfig)
+        );
     }
 }