Skip to content

DO-1765: Split playwright installation into separate step #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmthrgd-aligent merged 1 commit into from
Jul 1, 2026
Merged

DO-1765: Split playwright installation into separate step #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions .github/workflows/node-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,20 @@ jobs:
persist-credentials: false
clean: false

- name: Install Playwright
if: >-
inputs.skip-test-storybook == false &&
steps.check-test-storybook.outputs.exists == 'true'
run: |
# Ensure playwright dependencies are installed before story blok test execution begins
if [ "${INPUTS_PACKAGE_MANAGER}" = "yarn" ]; then
yarn playwright install --with-deps
else
npx playwright install --with-deps
fi
env:
INPUTS_PACKAGE_MANAGER: ${{ inputs.package-manager }}

- name: Build commands list
id: build-commands
run: |
Expand All @@ -470,12 +484,6 @@ jobs:
fi
if [ "${INPUTS_SKIP_TEST_STORYBOOK}" != "true" ] && \
[ "${STEPS_CHECK_TEST_STORYBOOK_OUTPUTS_EXISTS}" == "true" ]; then
# Ensure playwright dependencies are installed before story blok test execution begins
if [ "${INPUTS_PACKAGE_MANAGER}" = "yarn" ]; then
yarn playwright install --with-deps
else
npx playwright install --with-deps
fi
commands+=("${INPUTS_TEST_STORYBOOK_COMMAND}")
fi
if [ "${INPUTS_SKIP_CHECK_TYPES}" != "true" ] && \
Expand All @@ -493,7 +501,6 @@ jobs:
STEPS_CHECK_FORMAT_OUTPUTS_EXISTS: ${{ steps.check-format.outputs.exists }}
INPUTS_FORMAT_COMMAND: ${{ inputs.format-command }}
STEPS_CHECK_TEST_STORYBOOK_OUTPUTS_EXISTS: ${{ steps.check-test-storybook.outputs.exists }}
INPUTS_PACKAGE_MANAGER: ${{ inputs.package-manager }}
INPUTS_TEST_STORYBOOK_COMMAND: ${{ inputs.test-storybook-command }}
STEPS_CHECK_CHECK_TYPES_OUTPUTS_EXISTS: ${{ steps.check-check-types.outputs.exists }}
INPUTS_CHECK_TYPES_COMMAND: ${{ inputs.check-types-command }}
Expand Down