fix: sanitize process log control chars

Author: xXJSONDeruloXx

src/components/log-dock-component.ts

@@ -15,6 +15,7 @@ import type { Component } from "@mariozechner/pi-tui";
 import { truncateToWidth, visibleWidth } from "@mariozechner/pi-tui";
 import { LIVE_STATUSES } from "../constants";
 import type { ProcessManager } from "../manager";
+import { stripAnsi } from "../utils";
 import { LogFileViewer } from "./log-file-viewer";
 
 const PROCESS_COLORS: ThemeColor[] = [
@@ -153,7 +154,7 @@ export class LogDockComponent implements Component {
       const lastLogs = this.manager.getCombinedOutput(running[0].id, 1);
       if (lastLogs && lastLogs.length > 0) {
         const lastLog = truncateToWidth(
-          lastLogs[lastLogs.length - 1].text,
+          stripAnsi(lastLogs[lastLogs.length - 1].text),
           innerWidth,
         );
         lines.push(padLine(dim(lastLog)));

src/utils/ansi.test.ts

@@ -0,0 +1,25 @@
+import { describe, expect, it } from "vitest";
+import { stripAnsi } from "./ansi";
+
+describe("stripAnsi", () => {
+  it("strips CSI styling sequences", () => {
+    expect(stripAnsi("\u001b[31mred\u001b[0m")).toBe("red");
+  });
+
+  it("strips generic OSC sequences", () => {
+    expect(stripAnsi("\u001b]0;title\u0007hello")).toBe("hello");
+  });
+
+  it("strips carriage returns and other control chars that can corrupt TUI rendering", () => {
+    const output = stripAnsi("step 1\rstep 2\b\b done");
+    expect(output).toBe("step 1step 2 done");
+    for (const char of output) {
+      const code = char.codePointAt(0) ?? 0;
+      const isDisallowedC0 =
+        (code >= 0x00 && code <= 0x08) ||
+        (code >= 0x0b && code <= 0x1f) ||
+        code === 0x7f;
+      expect(isDisallowedC0).toBe(false);
+    }
+  });
+});

src/utils/ansi.ts

@@ -1,10 +1,11 @@
 /**
- * Strip ANSI escape codes from a string.
+ * Strip ANSI escape codes and other terminal control characters from a string.
  *
  * Removes:
  * - All CSI sequences (\x1b[...X) - SGR, cursor movement, erase, scroll, etc.
- * - OSC 8 hyperlinks (\x1b]8;;URL\x07)
+ * - OSC sequences (\x1b]...\x07 or \x1b]...\x1b\\)
  * - APC sequences (\x1b_...\x07 or \x1b_...\x1b\\)
+ * - Remaining C0 control chars except tab/newline
  */
 /**
  * Check if a string contains ANSI escape codes.
@@ -18,19 +19,33 @@ export function stripAnsi(str: string): string {
   const ESC = String.fromCodePoint(0x001b);
   const BEL = String.fromCodePoint(0x0007);
 
-  if (!str.includes(ESC)) {
-    return str;
-  }
+  let clean = str;
 
-  // Strip all CSI sequences (ESC[...X where X is any letter)
-  let clean = str.replace(new RegExp(`${ESC}\\[[0-9;]*[A-Za-z]`, "gu"), "");
-  // Strip OSC 8 hyperlinks: ESC]8;;URL<BEL> and ESC]8;;<BEL>
-  clean = clean.replace(new RegExp(`${ESC}\\]8;;[^${BEL}]*${BEL}`, "gu"), "");
-  // Strip APC sequences: ESC_...<BEL> or ESC_...<ESC>\\ (used for cursor marker)
-  clean = clean.replace(
-    new RegExp(`${ESC}_[^${BEL}${ESC}]*(?:${BEL}|${ESC}\\\\)`, "gu"),
-    "",
-  );
+  if (str.includes(ESC)) {
+    // Strip all CSI sequences (ESC[...X where X is any letter)
+    clean = clean.replace(new RegExp(`${ESC}\\[[0-9;]*[A-Za-z]`, "gu"), "");
+    // Strip OSC sequences: ESC]...<BEL> or ESC]...<ESC>\\
+    clean = clean.replace(
+      new RegExp(`${ESC}\\][^${BEL}${ESC}]*(?:${BEL}|${ESC}\\\\)`, "gu"),
+      "",
+    );
+    // Strip APC sequences: ESC_...<BEL> or ESC_...<ESC>\\ (used for cursor marker)
+    clean = clean.replace(
+      new RegExp(`${ESC}_[^${BEL}${ESC}]*(?:${BEL}|${ESC}\\\\)`, "gu"),
+      "",
+    );
+  }
 
-  return clean;
+  // Strip terminal control chars like carriage return/backspace that can
+  // corrupt TUI layout when rendered back into pi.
+  return Array.from(clean)
+    .filter((char) => {
+      const code = char.codePointAt(0) ?? 0;
+      const isDisallowedC0 =
+        (code >= 0x00 && code <= 0x08) ||
+        (code >= 0x0b && code <= 0x1f) ||
+        code === 0x7f;
+      return !isDisallowedC0;
+    })
+    .join("");
 }