fix: Prevent TUI rendering errors by stripping control chars#42
Merged
Conversation
f558ce6 to
88fd62d
Compare
Owner
|
Hey @xXJSONDeruloXx , thanks for this! Made some tweaks, merging this now and releasing it later today with other fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stripAnsi()Why
Some process output includes spinner/progress style control bytes such as bare
or�. Those bytes can make pi's TUI render orphaned, repeated, or cascading lines when log content is rendered back into widgets/components.This keeps the current output capture behavior intact, but hardens the render/sanitization path so control characters do not leak into the TUI.
Verification
npx pnpm testnpx pnpm typechecknpx pnpm lintTesting with a proc which helps repro this issue (one of various cases, but this is an extreme one for demo purposes):
Before:
After: