fix(agents): remove hardcoded developer path from hooks-guide bash steps#1050
Open
xiaolai wants to merge 1 commit into
Open
fix(agents): remove hardcoded developer path from hooks-guide bash steps#1050xiaolai wants to merge 1 commit into
xiaolai wants to merge 1 commit into
Conversation
Steps 5–6 in the hook generation workflow were hardcoded to /Users/rezarezvani/projects/claude-code-skills-factory, causing a directory-not-found error on every non-developer machine. The subsequent validator step (Step 3) already uses a relative path — this commit makes Steps 5–6 consistent with that pattern. Co-Authored-By: Claude Code <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: Steps 2 (both variants) in
hooks-guide.mdhardcode/Users/rezarezvani/projects/claude-code-skills-factory— this path does not exist on any other machine, so the hook generation steps fail with a directory-not-found error for all users.Evidence:
grep -n 'rezarezvani' .claude/agents/hooks-guide.mdreturns lines 253 and 259; runningcd /Users/rezarezvani/projects/claude-code-skills-factoryon a clean checkout exits withNo such file or directory.Fix: Remove the
cd /absolute/path &&prefix from both bash blocks, leaving only thepython3 generated-skills/hook-factory/hook_factory.py ...invocation — consistent with Step 3 (validator.py) which already uses a relative path.