[Feature] Support ESA CLI Sub Command#1345
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1345 +/- ##
==========================================
+ Coverage 84.00% 84.32% +0.31%
==========================================
Files 65 65
Lines 8495 8496 +1
==========================================
+ Hits 7136 7164 +28
+ Misses 917 894 -23
+ Partials 442 438 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AllyW
reviewed
Jun 9, 2026
| accessKeyId = profile.AccessKeyId | ||
| accessKeySecret = profile.AccessKeySecret | ||
| stsToken = profile.StsToken | ||
| case config.RamRoleArn: |
Collaborator
There was a problem hiding this comment.
The other profile mode should be the same
AllyW
reviewed
Jun 9, 2026
| envs = append(envs, "ALIBABA_CLOUD_REGION_ID="+profile.RegionId) | ||
| } | ||
|
|
||
| envs = append(envs, "ALIBABA_CLOUD_ESA_CLI_COMPAT_MODE=aliyun esa-cli") |
Collaborator
There was a problem hiding this comment.
Add to command usage template in esa-cli
使用 GetCredential 兜底处理所有认证模式，支持 EcsRamRole、OIDC 等， 同时修复错误被静默吞掉的问题。 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
LGTM，ready to merge after next esa-cli release |
AllyW
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.