Merge branch 'main' into dependabot/github_actions/toolmantim/release-drafter-6.1.0

Author: janisz

.github/workflows/build.yml

@@ -21,10 +21,10 @@ jobs:
         id: go
 
       - name: Check out code into the Go module directory
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
 
       - name: Lint code
-        uses: golangci/golangci-lint-action@v6
+        uses: golangci/golangci-lint-action@e7fa5ac41e1cf5b7d48e45e42232ce7ada589601
         with:
           only-new-issues: true
 

.golangci.yaml

@@ -1,8 +1,27 @@
+version: "2"
 linters:
   disable:
     - errcheck
-linters-settings:
-  staticcheck:
-    checks:
-    - all
-    - '-SA1019'
+  settings:
+    staticcheck:
+      checks:
+        - -SA1019
+        - all
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

README.md

@@ -12,8 +12,9 @@ Requires Go 1.12 or newer.
 
 ```go
 import (
-	"fmt"
 	"context"
+	"fmt"
+	"time"
 	"github.com/allegro/bigcache/v3"
 )
 
@@ -32,7 +33,10 @@ allocation can be avoided in that way.
 
 ```go
 import (
+	"context"
+	"fmt"
 	"log"
+	"time"
 
 	"github.com/allegro/bigcache/v3"
 )

assert_test.go

@@ -24,8 +24,8 @@ func noError(t *testing.T, e error) {
 	if e != nil {
 		_, file, line, _ := runtime.Caller(1)
 		file = path.Base(file)
-		t.Errorf(fmt.Sprintf("\n%s:%d: Error is not nil: \n"+
-			"actual  : %T(%#v)\n", file, line, e, e))
+		t.Errorf("\n%s:%d: Error is not nil: \n"+
+			"actual  : %T(%#v)\n", file, line, e, e)
 	}
 }
 

bigcache.go

@@ -57,7 +57,7 @@ func NewBigCache(config Config) (*BigCache, error) {
 
 func newBigCache(ctx context.Context, config Config, clock clock) (*BigCache, error) {
 	if !isPowerOfTwo(config.Shards) {
-		return nil, errors.New("Shards number must be power of two")
+		return nil, errors.New("Shards number must be power of two") //nolint:staticcheck // keep for backward compatibility
 	}
 	if config.MaxEntrySize < 0 {
 		return nil, errors.New("MaxEntrySize must be >= 0")

bytes_appengine.go

@@ -1,5 +1,4 @@
 //go:build appengine
-// +build appengine
 
 package bigcache
 

entry_not_found_error.go

@@ -4,5 +4,5 @@ import "errors"
 
 var (
 	// ErrEntryNotFound is an error type struct which is returned when entry was not found for provided key
-	ErrEntryNotFound = errors.New("Entry not found")
+	ErrEntryNotFound = errors.New("Entry not found") //nolint:staticcheck // keep for backward compatibility
 )

iterator_test.go

@@ -219,10 +219,8 @@ func TestParallelSetAndIteration(t *testing.T) {
 
 		isTimeout := false
 
-		for {
-			if isTimeout {
-				break
-			}
+		for !isTimeout {
+
 			select {
 			case <-ctx.Done():
 				isTimeout = true
@@ -244,10 +242,8 @@ func TestParallelSetAndIteration(t *testing.T) {
 
 		isTimeout := false
 
-		for {
-			if isTimeout {
-				break
-			}
+		for !isTimeout {
+
 			select {
 			case <-ctx.Done():
 				isTimeout = true

queue/bytes_queue.go

@@ -17,6 +17,7 @@ var (
 	errEmptyQueue       = &queueError{"Empty queue"}
 	errInvalidIndex     = &queueError{"Index must be greater than zero. Invalid index."}
 	errIndexOutOfBounds = &queueError{"Index out of range"}
+	errFullQueue        = &queueError{"Full queue. Maximum size limit reached."}
 )
 
 // BytesQueue is a non-thread safe queue type of fifo based on bytes array.
@@ -92,7 +93,7 @@ func (q *BytesQueue) Push(data []byte) (int, error) {
 		if q.canInsertBeforeHead(neededSize) {
 			q.tail = leftMarginIndex
 		} else if q.capacity+neededSize >= q.maxCapacity && q.maxCapacity > 0 {
-			return -1, &queueError{"Full queue. Maximum size limit reached."}
+			return -1, errFullQueue
 		} else {
 			q.allocateAdditionalMemory(neededSize)
 		}