Don't match path on prefix alone#68
Merged
KostkaBrukowa merged 1 commit intoallegro:masterfrom Mar 7, 2024
Merged
Conversation
|
would love to see this merged if it passes tests. I have the same issue. |
|
if anyone else ends up here, I ended up for now just using pnpm's built in |
KostkaBrukowa
added a commit
that referenced
this pull request
Mar 7, 2024
Collaborator
|
Thanks for contribution! Published with |
|
Hey. My use case was to use exact file path like |
Contributor
Author
|
@solomkinmv If you want to contribute, I think a fix would be: const posixFilePath = getPosixFilePath(filePath);
const posixStrictPath = getPosixFilePath(absolutePathToStrictFiles);
return posixFilePath === posixStrictPath || posixFilePath.startsWith(posixStrictPath + path.posix.sep); |
|
This breaks every file paths. So the {
"compilerOptions": {
...
"strict": false,
"plugins": [
{
"name": "typescript-strict-plugin",
"paths": [
"./src",
"/absolute/path/to/source/"
],
"exclude": [
"./src/tests",
"./src/fileToExclude.ts"
],
"excludePattern": [
"**/*.spec.ts"
]
}
]
}
} |
|
Submitted a PR (#86) to fix this. Thanks @heyimalex! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that
path/to/goodwas matchingpath/to/goodness-no/file.ts, so just the prefix and not the exact directory. I will maybe add tests this weekend.