Attempt to fix as many sizer warnings as possible#41
Open
ntninja wants to merge 8 commits into
Open
Conversation
Contributor
Author
|
For context I’m taking these kinds of visual issues that happen when 
(This one is fixed by the most recent commit, but many others remain.) |
…RTICAL)) failed in DoInsert()
…when combined with wxEXPAND
…base Unfortunately all dialogs will need manual review, since the contraditionary options are no longer guessed by WX and hence cause weird dialog item sizing without manual triage.
This was done using automated replacement, so some dialogs continue to look problematic. To fix all instances of this every dialog will need to be manually reviewed unfortunately.
ntninja
force-pushed
the
rftr-sizer-warnings
branch
from
August 30, 2025 13:59
2d6710d to
ded8170
Compare
Contributor
Author
|
@gilbertoca: What are you trying to tell me? I did exactly what you said in #44 and also my This PR is for sizer fixes, so it obviously doesn’t have those changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this relied on automated replacements a lot, it unfortunately is imperfect:
wxEXPANDnow don’t, see the last commit for an example of how to fix those instances case-by-caseAlso includes #35 #37 from @gilbertoca, as these were that base that I iterated from.