Skip to content

Allow creating Autocompletes with 'show_view_link' => true#694

Open
dlh01 wants to merge 1 commit into
mainfrom
show-view-link
Open

Allow creating Autocompletes with 'show_view_link' => true#694
dlh01 wants to merge 1 commit into
mainfrom
show-view-link

Conversation

@dlh01

@dlh01 dlh01 commented Feb 13, 2018

Copy link
Copy Markdown
Member

This field currently generates a FM_Developer_Exception:

add_action( 'fm_post', function ( $type ) {
	$fm = new \Fieldmanager_Autocomplete( 'Foo', [
		'name' => 'foo',
		'show_view_link' => true,
		'datasource' => new \Fieldmanager_Datasource_Post(),
	] );
	$fm->add_meta_box( 'Bar', $type );
} );

because show_view_link is not a property on \Fieldmanager_Autocomplete. But everything else seems to be set up for it to work (with posts and terms, anyway).

A workaround is to just set $fm->show_view_link = true after instantiating the class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant