Skip to content

[Bug]: DHooks does not report safetyhook's errors #2382

@cafeed28

Description

@cafeed28

Prerequisites

  • I have checked that my issue doesn't exist yet in the issue tracker

Operating System and Version

Windows 10 22H2

Game / AppID and Version

CS:SO 2.0 beta 6

SourceMod Version

1.13.0.7279

Metamod:Source Version

2.0.0-dev+1367

Version Verification

Updated SourceMod Version

No response

Updated Metamod:Source Version

No response

Description

If safetyhook::InlineHook::create or m_Hook.enable fails, CHook::CHook does not report error to CHookManager::HookFunction and Native_EnableDetour, so if safetyhook fails for any reason, plugin that uses DynamicDetour has no way to know if DynamicDetour.Enable has failed

Steps to Reproduce

No response

Relevant Log Output

Metadata

Metadata

Assignees

Labels

Buggeneral bugs; can be anything

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions