Refactor for modern C++ features and cleanup.

Replaced legacy I/O functions (`fprintf`, `printf`) with modern `<print>` utilities for improved readability and safety. Updated function signatures to use `const` references where appropriate and removed redundant `else` clauses. Simplified the valgrind command by removing unused suppression file, and deleted the obsolete `valgrind.supp` file.

Author: allnes

modules/core/task/include/task.hpp

@@ -25,20 +25,19 @@ enum StatusOfTask : uint8_t { kEnabled, kDisabled };
 inline std::string GetStringTaskStatus(StatusOfTask status_of_task) {
   if (status_of_task == kDisabled) {
     return "disabled";
-  } else {
-    return "enabled";
   }
+  return "enabled";
 }
 
-inline std::string GetStringTaskType(TypeOfTask type_of_task, std::string settings_file_path) {
+inline std::string GetStringTaskType(TypeOfTask type_of_task, const std::string &settings_file_path) {
   std::ifstream file(settings_file_path);
   if (!file.is_open()) {
     throw std::runtime_error("Failed to open file settings.json");
   }
   nlohmann::json list_settings;
   file >> list_settings;
 
-  auto to_type_str = [&](std::string type) -> std::string {
+  auto to_type_str = [&](const std::string &type) -> std::string {
     return type + "_" + std::string(list_settings["tasks"][type]);
   };
 

scripts/run_tests.py

@@ -31,9 +31,7 @@ def __init__(self):
         self.__ppc_env = None
         self.work_dir = None
 
-        suppression_file = Path(self.__get_project_path()) / "valgrind.supp"
-        self.valgrind_cmd = (f"valgrind --suppressions={suppression_file} "
-                             f"--error-exitcode=1 --leak-check=full --show-leak-kinds=all")
+        self.valgrind_cmd = "valgrind --error-exitcode=1 --leak-check=full --show-leak-kinds=all"
 
         if platform.system() == "Windows":
             self.mpi_exec = "mpiexec"

tasks/runners/functional.cpp

@@ -3,8 +3,8 @@
 #include <omp.h>
 
 #include <cstdio>
-#include <cstdlib>
 #include <memory>
+#include <print>
 #include <string>
 #include <utility>
 
@@ -27,12 +27,11 @@ class UnreadMessagesDetector : public ::testing::EmptyTestEventListener {
     MPI_Iprobe(MPI_ANY_SOURCE, MPI_ANY_TAG, MPI_COMM_WORLD, &flag, &status);
 
     if (flag != 0) {
-      fprintf(
+      std::println(
           stderr,
-          "[  PROCESS %d  ] [  FAILED  ] %s.%s: MPI message queue has an unread message from process %d with tag %d\n",
+          "[  PROCESS {}  ] [  FAILED  ] {}.{}: MPI message queue has an unread message from process {} with tag {}",
           rank, "test_suite_name", "test_name", status.MPI_SOURCE, status.MPI_TAG);
-      MPI_Finalize();
-      std::terminate();
+      exit(EXIT_FAILURE);  // NOLINT
     }
 
     MPI_Barrier(MPI_COMM_WORLD);
@@ -65,7 +64,7 @@ class WorkerTestFailurePrinter : public ::testing::EmptyTestEventListener {
   static void PrintProcessRank() {
     int rank = -1;
     MPI_Comm_rank(MPI_COMM_WORLD, &rank);
-    printf(" [  PROCESS %d  ] ", rank);
+    std::print(" [  PROCESS {}  ] ", rank);
   }
 
   std::shared_ptr<::testing::TestEventListener> base_;

tasks/runners/performance.cpp

@@ -3,8 +3,8 @@
 #include <omp.h>
 
 #include <cstdio>
-#include <cstdlib>
 #include <memory>
+#include <print>
 #include <string>
 #include <utility>
 
@@ -27,12 +27,11 @@ class UnreadMessagesDetector : public ::testing::EmptyTestEventListener {
     MPI_Iprobe(MPI_ANY_SOURCE, MPI_ANY_TAG, MPI_COMM_WORLD, &flag, &status);
 
     if (flag != 0) {
-      fprintf(
-          stderr,
-          "[  PROCESS %d  ] [  FAILED  ] %s.%s: MPI message queue has an unread message from process %d with tag %d\n",
-          rank, "test_suite_name", "test_name", status.MPI_SOURCE, status.MPI_TAG);
-      MPI_Finalize();
-      std::terminate();
+      std::println(stderr,
+                   "[  PROCESS {}  ] [  FAILED  ] MPI message queue has an unread message from process {} with tag {}",
+                   rank, status.MPI_SOURCE, status.MPI_TAG);
+
+      exit(EXIT_FAILURE);  // NOLINT
     }
 
     MPI_Barrier(MPI_COMM_WORLD);
@@ -65,7 +64,7 @@ class WorkerTestFailurePrinter : public ::testing::EmptyTestEventListener {
   static void PrintProcessRank() {
     int rank = -1;
     MPI_Comm_rank(MPI_COMM_WORLD, &rank);
-    printf(" [  PROCESS %d  ] ", rank);
+    std::print(" [  PROCESS {}  ] ", rank);
   }
 
   std::shared_ptr<::testing::TestEventListener> base_;