feat(chat)!: remove remaining Cloud upsells + apply formatter drift (3.53.11)

Task 1 — purge remaining upsell plumbing:
* ChatView.tsx — drop the dead useCloudUpsell hook call + <CloudUpsellDialog>
  render (nothing in ChatView calls openUpsell after the prior banner removal).
* webviewMessageHandler.ts — remove dismissUpsell / getDismissedUpsells cases.
  No remaining webview code dispatches them.
* vscode-extension-host.ts — drop "dismissUpsell" / "getDismissedUpsells"
  from WebviewMessage types, "dismissedUpsells" from ExtensionMessage +
  ExtensionState picks, and the upsellId?/list? fields that only existed
  for these handlers.
* global-settings.ts — drop dismissedUpsells: z.array(z.string()).optional()
  from globalSettingsSchema.
* All 18 cloud.json locales — drop the "upsell" object (its only two keys,
  autoApprovePowerUser and taskList, were already orphaned with no code
  references after the banner removal).

Kept intact (legitimate user-initiated flows):
* useCloudUpsell hook + CloudUpsellDialog component — still used by
  ShareButton to prompt sign-in when user clicks Share unauthenticated.
* renderCloudBenefitsContent — still rendered by CloudView as the sign-in
  landing page on the Cloud tab itself, which users open intentionally.

Task 2 — formatter drift cleanup:
Re-ran `pnpm format` across the monorepo. The prettier-driven whitespace
changes (inlined single-line imports, removed stray blank lines in catch
blocks) are purely cosmetic — no functional impact. Both check-types and
lint pass cleanly across all 13 packages. Full test sweep: 1253 webview
+ 5431 src + 115 types tests pass.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: allquixotic

packages/types/src/global-settings.ts

@@ -83,7 +83,6 @@ export const globalSettingsSchema = z.object({
 	pinnedApiConfigs: z.record(z.string(), z.boolean()).optional(),
 	customInstructions: z.string().optional(),
 	taskHistory: z.array(historyItemSchema).optional(),
-	dismissedUpsells: z.array(z.string()).optional(),
 
 	// Image generation settings (experimental) - flattened for simplicity
 	imageGenerationProvider: z.enum(["openrouter", "roo"]).optional(),

packages/types/src/vscode-extension-host.ts

@@ -87,7 +87,6 @@ export interface ExtensionMessage {
 		| "showEditMessageDialog"
 		| "commands"
 		| "insertTextIntoTextarea"
-		| "dismissedUpsells"
 		| "organizationSwitchResult"
 		| "interactionRequired"
 		| "customToolsResult"
@@ -178,7 +177,6 @@ export interface ExtensionMessage {
 	context?: string
 	commands?: Command[]
 	queuedMessages?: QueuedMessage[]
-	list?: string[] // For dismissedUpsells
 	organizationId?: string | null // For organizationSwitchResult
 	tools?: SerializedCustomToolDefinition[] // For customToolsResult
 	skills?: SkillMetadata[] // For skills response
@@ -266,7 +264,6 @@ export type ExtensionState = Pick<
 	| "listApiConfigMeta"
 	| "pinnedApiConfigs"
 	| "customInstructions"
-	| "dismissedUpsells"
 	| "autoApprovalEnabled"
 	| "yoloMode"
 	| "alwaysAllowReadOnly"
@@ -562,8 +559,6 @@ export interface WebviewMessage {
 		| "queueMessage"
 		| "removeQueuedMessage"
 		| "editQueuedMessage"
-		| "dismissUpsell"
-		| "getDismissedUpsells"
 		| "openMarkdownPreview"
 		| "updateSettings"
 		| "allowedCommands"
@@ -659,8 +654,6 @@ export interface WebviewMessage {
 	visibility?: ShareVisibility // For share visibility
 	hasContent?: boolean // For checkRulesDirectoryResult
 	checkOnly?: boolean // For deleteCustomMode check
-	upsellId?: string // For dismissUpsell
-	list?: string[] // For dismissedUpsells response
 	organizationId?: string | null // For organization switching
 	useProviderSignup?: boolean // For rooCloudSignIn to use provider signup flow
 	codeIndexSettings?: {

src/__tests__/nested-delegation-resume.spec.ts

@@ -8,7 +8,6 @@ vi.mock("safe-stable-stringify", () => ({
 	default: (obj: any) => JSON.stringify(obj),
 }))
 
-
 // vscode mock for Task/Provider imports
 vi.mock("vscode", () => {
 	const window = {

src/api/providers/__tests__/bedrock-error-handling.spec.ts

@@ -1,4 +1,3 @@
-
 // Mock BedrockRuntimeClient and commands
 const mockSend = vi.fn()
 

src/api/providers/__tests__/gemini.spec.ts

@@ -13,7 +13,6 @@ describe("GeminiHandler", () => {
 	let handler: GeminiHandler
 
 	beforeEach(() => {
-
 		// Create mock functions
 		const mockGenerateContentStream = vitest.fn()
 		const mockGenerateContent = vitest.fn()
@@ -244,5 +243,4 @@ describe("GeminiHandler", () => {
 			expect(cost).toBeUndefined()
 		})
 	})
-
 })

src/api/providers/__tests__/mistral.spec.ts

@@ -1,4 +1,3 @@
-
 // Mock Mistral client - must come before other imports
 const mockCreate = vi.fn()
 const mockComplete = vi.fn()

src/api/providers/__tests__/openai-native.spec.ts

@@ -1100,7 +1100,6 @@ describe("OpenAiNativeHandler", () => {
 			}
 		})
 	})
-
 })
 
 // Additional tests for GPT-5 streaming event coverage

src/api/providers/fetchers/__tests__/modelCache.spec.ts

@@ -1,6 +1,5 @@
 // Mocks must come first, before imports
 
-
 // Mock NodeCache to allow controlling cache behavior
 vi.mock("node-cache", () => {
 	const mockGet = vi.fn().mockReturnValue(undefined)

src/api/providers/gemini.ts

@@ -9,12 +9,7 @@ import {
 } from "@google/genai"
 import type { JWTInput } from "google-auth-library"
 
-import {
-	type ModelInfo,
-	type GeminiModelId,
-	geminiDefaultModelId,
-	geminiModels,
-} from "@roo-code/types"
+import { type ModelInfo, type GeminiModelId, geminiDefaultModelId, geminiModels } from "@roo-code/types"
 import { safeJsonParse } from "@roo-code/core"
 
 import type { ApiHandlerOptions } from "../../shared/api"
@@ -331,7 +326,6 @@ export class GeminiHandler extends BaseProvider implements SingleCompletionHandl
 				}
 			}
 		} catch (error) {
-
 			if (error instanceof Error) {
 				throw new Error(t("common:errors.gemini.generate_stream", { error: error.message }))
 			}
@@ -437,7 +431,6 @@ export class GeminiHandler extends BaseProvider implements SingleCompletionHandl
 
 			return text
 		} catch (error) {
-
 			if (error instanceof Error) {
 				throw new Error(t("common:errors.gemini.generate_complete_prompt", { error: error.message }))
 			}

src/api/providers/mistral.ts

@@ -2,12 +2,7 @@ import { Anthropic } from "@anthropic-ai/sdk"
 import { Mistral } from "@mistralai/mistralai"
 import OpenAI from "openai"
 
-import {
-	type MistralModelId,
-	mistralDefaultModelId,
-	mistralModels,
-	MISTRAL_DEFAULT_TEMPERATURE,
-} from "@roo-code/types"
+import { type MistralModelId, mistralDefaultModelId, mistralModels, MISTRAL_DEFAULT_TEMPERATURE } from "@roo-code/types"
 
 import { ApiHandlerOptions } from "../../shared/api"