Shadow: Fix TanStack Router lint resolution in test app (v1)#100
Open
allspain wants to merge 1 commit into
Open
Shadow: Fix TanStack Router lint resolution in test app (v1)#100allspain wants to merge 1 commit into
allspain wants to merge 1 commit into
Conversation
Add the missing TypeScript path mapping for `@datadog/browser-rum-react/tanstack-router` in the repo and test app configs so type-aware ESLint can resolve the subpath package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shadow Review — PR
#4513v1Source:
DataDog/browser-sdk#4513Commit:
c75e8ec0da1f0ea33fb67c23327abfb868c87f0cTimestamp: 2026-04-21T08:13:46Z
Original PR Description
Motivation
The TanStack Router test app was already importing
@datadog/browser-rum-react/tanstack-router, but our TypeScript config did not include a matching path alias for that subpath. As a result, type-aware ESLint could not resolve the import andyarn lintfailed.Changes
@datadog/browser-rum-react/tanstack-routerpath alias to the repo-leveltsconfig.base.jsontest/apps/tanstack-router-app/tsconfig.jsonso the test app's local type-aware linting also resolves the package correctlyThis is a config-only fix. It does not change runtime behavior.
Test instructions
yarn lintfrom the repository root.test/apps/tanstack-router-app/app.tsxno longer appears.Checklist