fix missing context warnings

baev · baev · commit 0e4927954b20 · 2026-07-03T09:51:09.000+01:00
diff --git a/allure-cucumber7-jvm/src/main/java/io/qameta/allure/cucumber7jvm/AllureCucumber7Jvm.java b/allure-cucumber7-jvm/src/main/java/io/qameta/allure/cucumber7jvm/AllureCucumber7Jvm.java
@@ -63,6 +63,7 @@
 import java.util.Optional;
 import java.util.UUID;
 import java.util.concurrent.ConcurrentHashMap;
+import java.util.function.Supplier;
 import java.util.stream.Collectors;
 import java.util.stream.IntStream;
 import java.util.stream.Stream;
@@ -342,7 +343,7 @@ private void handleWriteEvent(final WriteEvent event) {
         addAttachmentToCurrent(
                 "Text output",
                 TEXT_PLAIN,
-                new ByteArrayInputStream(Objects.toString(event.getText()).getBytes(StandardCharsets.UTF_8)),
+                () -> new ByteArrayInputStream(Objects.toString(event.getText()).getBytes(StandardCharsets.UTF_8)),
                 AttachmentOptions.empty()
         );
     }
@@ -351,7 +352,7 @@ private void handleEmbedEvent(final EmbedEvent event) {
         addAttachmentToCurrent(
                 event.name,
                 event.getMediaType(),
-                new ByteArrayInputStream(event.getData()),
+                () -> new ByteArrayInputStream(event.getData()),
                 AttachmentOptions.empty()
         );
     }
@@ -440,6 +441,15 @@ private List<Parameter> getExamplesAsParameters(
     }
 
     private void createDataTableAttachment(final DataTableArgument dataTableArgument) {
+        addAttachmentToCurrent(
+                "Data table",
+                "text/csv",
+                () -> new ByteArrayInputStream(toCsv(dataTableArgument).getBytes(StandardCharsets.UTF_8)),
+                AttachmentOptions.empty()
+        );
+    }
+
+    private static String toCsv(final DataTableArgument dataTableArgument) {
         final List<List<String>> rowsInTable = dataTableArgument.cells();
         final StringBuilder dataTableCsv = new StringBuilder();
         for (List<String> columns : rowsInTable) {
@@ -459,23 +469,22 @@ private void createDataTableAttachment(final DataTableArgument dataTableArgument
                 dataTableCsv.append(rowValue);
             }
         }
-        addAttachmentToCurrent(
-                "Data table",
-                "text/csv",
-                new ByteArrayInputStream(dataTableCsv.toString().getBytes(StandardCharsets.UTF_8)),
-                AttachmentOptions.empty()
-        );
+        return dataTableCsv.toString();
     }
 
+    /**
+     * Attaches to the current executable, or silently skips — including the content computation — when no
+     * executable is running (for example when Allure reporting is disabled).
+     */
     private void addAttachmentToCurrent(final String name, final String type,
-                                        final InputStream stream, final AttachmentOptions options) {
+                                        final Supplier<InputStream> content, final AttachmentOptions options) {
         lifecycle.getCurrentExecutableKey()
                 .ifPresent(
                         key -> lifecycle.addAttachment(
                                 key,
                                 name,
                                 type,
-                                stream,
+                                content.get(),
                                 options
                         )
                 );
diff --git a/allure-hamcrest/src/main/java/io/qameta/allure/hamcrest/AllureHamcrestAssert.java b/allure-hamcrest/src/main/java/io/qameta/allure/hamcrest/AllureHamcrestAssert.java
@@ -91,6 +91,11 @@ public void initAssertThat() {
      */
     @Before("initAssertThat()")
     public void catchAndStartStep(final JoinPoint joinPoint) {
+        // enrichment-only integration: silently skip when no executable is running,
+        // so a disabled Allure reporter produces no warnings and no wasted work
+        if (getLifecycle().getCurrentExecutableKey().isEmpty()) {
+            return;
+        }
         if (joinPoint.getArgs().length == 3) {
             final String reason = (String) joinPoint.getArgs()[0];
             final String actual = ObjectUtils.toString(joinPoint.getArgs()[1]);
@@ -121,6 +126,9 @@ public void catchAndStartStep(final JoinPoint joinPoint) {
      * @param e the e
      */
     public void stepFailed(final Throwable e) {
+        if (getLifecycle().getCurrentExecutableKey().isEmpty()) {
+            return;
+        }
         getLifecycle().updateStep(s -> s.setStatus(getStatus(e).orElse(Status.BROKEN)));
         getLifecycle().stopStep();
     }
@@ -130,6 +138,9 @@ public void stepFailed(final Throwable e) {
      */
     @AfterReturning(pointcut = "initAssertThat()")
     public void stepStop() {
+        if (getLifecycle().getCurrentExecutableKey().isEmpty()) {
+            return;
+        }
         getLifecycle().updateStep(s -> s.setStatus(Status.PASSED));
         getLifecycle().stopStep();
     }
diff --git a/allure-hamcrest/src/test/java/io/qameta/allure/hamcrest/AllureHamcrestNoContextTest.java b/allure-hamcrest/src/test/java/io/qameta/allure/hamcrest/AllureHamcrestNoContextTest.java
@@ -0,0 +1,40 @@
+/*
+ *  Copyright 2016-2026 Qameta Software Inc
+ *
+ *  Licensed under the Apache License, Version 2.0 (the "License");
+ *  you may not use this file except in compliance with the License.
+ *  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+package io.qameta.allure.hamcrest;
+
+import io.qameta.allure.test.AllureResults;
+import org.hamcrest.MatcherAssert;
+import org.hamcrest.Matchers;
+import org.junit.jupiter.api.Test;
+
+import static io.qameta.allure.test.RunUtils.runTests;
+import static org.assertj.core.api.Assertions.assertThat;
+
+/**
+ * Hamcrest asserts are enrichment-only: with no Allure executable running (for example when the reporter is
+ * disabled), the aspect must skip silently — no step results, no warnings, and the assert itself still executes.
+ */
+class AllureHamcrestNoContextTest {
+
+    @Test
+    void shouldSkipSilentlyWithoutTestContext() {
+        final AllureResults results = runTests(lifecycle ->
+                MatcherAssert.assertThat("the assert still runs", Matchers.notNullValue()));
+
+        assertThat(results.getTestResults()).isEmpty();
+        assertThat(results.getTestResultContainers()).isEmpty();
+    }
+}
diff --git a/allure-httpclient/src/main/java/io/qameta/allure/httpclient/AllureHttpClientRequest.java b/allure-httpclient/src/main/java/io/qameta/allure/httpclient/AllureHttpClientRequest.java
@@ -15,6 +15,7 @@
  */
 package io.qameta.allure.httpclient;
 
+import io.qameta.allure.Allure;
 import io.qameta.allure.http.HttpExchangeBody;
 import io.qameta.allure.http.HttpExchangeRequest;
 import org.apache.http.Header;
@@ -46,6 +47,11 @@ public class AllureHttpClientRequest implements HttpRequestInterceptor {
     public void process(final HttpRequest request,
                         final HttpContext context)
             throws IOException {
+        // enrichment-only integration: silently skip when no executable is running,
+        // so a disabled Allure reporter produces no warnings and no body copying
+        if (Allure.getLifecycle().getCurrentExecutableKey().isEmpty()) {
+            return;
+        }
 
         final HttpExchangeRequest.Builder builder = HttpExchangeRequest
                 .builder(request.getRequestLine().getMethod(), request.getRequestLine().getUri());
diff --git a/allure-httpclient/src/main/java/io/qameta/allure/httpclient/AllureHttpClientResponse.java b/allure-httpclient/src/main/java/io/qameta/allure/httpclient/AllureHttpClientResponse.java
@@ -63,6 +63,11 @@ public AllureHttpClientResponse configureHttpExchange(final Consumer<HttpExchang
     public void process(final HttpResponse response,
                         final HttpContext context)
             throws IOException {
+        // enrichment-only integration: silently skip when no executable is running,
+        // so a disabled Allure reporter produces no warnings and no entity buffering
+        if (Allure.getLifecycle().getCurrentExecutableKey().isEmpty()) {
+            return;
+        }
 
         final HttpExchangeResponse.Builder builder = HttpExchangeResponse.builder()
                 .setStatus(response.getStatusLine().getStatusCode())
diff --git a/allure-httpclient5/src/main/java/io/qameta/allure/httpclient5/AllureHttpClient5Request.java b/allure-httpclient5/src/main/java/io/qameta/allure/httpclient5/AllureHttpClient5Request.java
@@ -15,6 +15,7 @@
  */
 package io.qameta.allure.httpclient5;
 
+import io.qameta.allure.Allure;
 import io.qameta.allure.http.HttpExchangeBody;
 import io.qameta.allure.http.HttpExchangeRequest;
 import org.apache.hc.core5.http.EntityDetails;
@@ -46,6 +47,11 @@ public class AllureHttpClient5Request implements HttpRequestInterceptor {
     public void process(final HttpRequest request,
                         final EntityDetails entity,
                         final HttpContext context) {
+        // enrichment-only integration: silently skip when no executable is running,
+        // so a disabled Allure reporter produces no warnings and no body copying
+        if (Allure.getLifecycle().getCurrentExecutableKey().isEmpty()) {
+            return;
+        }
         final HttpExchangeRequest.Builder builder = HttpExchangeRequest
                 .builder(request.getMethod(), request.getRequestUri());
 
diff --git a/allure-httpclient5/src/main/java/io/qameta/allure/httpclient5/AllureHttpClient5Response.java b/allure-httpclient5/src/main/java/io/qameta/allure/httpclient5/AllureHttpClient5Response.java
@@ -70,6 +70,11 @@ public void process(final HttpResponse response,
                         final EntityDetails entity,
                         final HttpContext context)
             throws IOException {
+        // enrichment-only integration: silently skip when no executable is running,
+        // so a disabled Allure reporter produces no warnings and no entity buffering
+        if (Allure.getLifecycle().getCurrentExecutableKey().isEmpty()) {
+            return;
+        }
         final HttpExchangeResponse.Builder builder = HttpExchangeResponse.builder()
                 .setStatus(response.getCode())
                 .setStatusText(response.getReasonPhrase());
diff --git a/allure-java-commons/src/main/java/io/qameta/allure/aspects/AttachmentsAspects.java b/allure-java-commons/src/main/java/io/qameta/allure/aspects/AttachmentsAspects.java
@@ -74,6 +74,12 @@ public void anyMethod() {
             returning = "result"
     )
     public void attachment(final JoinPoint joinPoint, final Object result) {
+        // enrichment aspect: silently skip — including the content conversion — when no
+        // executable is running, so a disabled Allure reporter produces no warnings
+        final AllureLifecycle lifecycle = getLifecycle();
+        if (lifecycle.getCurrentExecutableKey().isEmpty()) {
+            return;
+        }
         final MethodSignature methodSignature = (MethodSignature) joinPoint.getSignature();
         final Attachment attachment = methodSignature.getMethod()
                 .getAnnotation(Attachment.class);
@@ -85,17 +91,14 @@ public void attachment(final JoinPoint joinPoint, final Object result) {
         final String name = attachment.value().isEmpty()
                 ? methodSignature.getName()
                 : processNameTemplate(attachment.value(), getParametersMap(joinPoint));
-        final AllureLifecycle lifecycle = getLifecycle();
-        if (lifecycle.getCurrentExecutableKey().isPresent()) {
-            lifecycle.addAttachment(
-                    name,
-                    attachment.type(),
-                    new ByteArrayInputStream(bytes),
-                    attachment.fileExtension().isEmpty()
-                            ? AttachmentOptions.empty()
-                            : AttachmentOptions.withFileExtension(attachment.fileExtension())
-            );
-        }
+        lifecycle.addAttachment(
+                name,
+                attachment.type(),
+                new ByteArrayInputStream(bytes),
+                attachment.fileExtension().isEmpty()
+                        ? AttachmentOptions.empty()
+                        : AttachmentOptions.withFileExtension(attachment.fileExtension())
+        );
     }
 
     /**
diff --git a/allure-java-commons/src/main/java/io/qameta/allure/aspects/StepsAspects.java b/allure-java-commons/src/main/java/io/qameta/allure/aspects/StepsAspects.java
@@ -74,6 +74,11 @@ public void anyMethod() {
      */
     @Before("anyMethod() && withStepAnnotation()")
     public void stepStart(final JoinPoint joinPoint) {
+        // enrichment aspect: silently skip when no executable is running,
+        // so a disabled Allure reporter produces no warnings and no wasted work
+        if (getLifecycle().getCurrentExecutableKey().isEmpty()) {
+            return;
+        }
         final MethodSignature methodSignature = (MethodSignature) joinPoint.getSignature();
         final Step step = methodSignature.getMethod().getAnnotation(Step.class);
 
@@ -97,6 +102,9 @@ public void stepStart(final JoinPoint joinPoint) {
             throwing = "e"
     )
     public void stepFailed(final Throwable e) {
+        if (getLifecycle().getCurrentExecutableKey().isEmpty()) {
+            return;
+        }
         getLifecycle().updateStep(
                 s -> s
                         .setStatus(getStatus(e).orElse(Status.BROKEN))
@@ -110,6 +118,9 @@ public void stepFailed(final Throwable e) {
      */
     @AfterReturning(pointcut = "anyMethod() && withStepAnnotation()")
     public void stepStop() {
+        if (getLifecycle().getCurrentExecutableKey().isEmpty()) {
+            return;
+        }
         getLifecycle().updateStep(s -> s.setStatus(Status.PASSED));
         getLifecycle().stopStep();
     }
diff --git a/allure-jax-rs/src/main/java/io/qameta/allure/jaxrs/AllureJaxRs.java b/allure-jax-rs/src/main/java/io/qameta/allure/jaxrs/AllureJaxRs.java
@@ -64,6 +64,11 @@ public AllureJaxRs configureHttpExchange(final Consumer<HttpExchange.Builder> ex
      */
     @Override
     public void filter(final ClientRequestContext requestContext) {
+        // enrichment-only integration: silently skip when no executable is running,
+        // so a disabled Allure reporter produces no warnings and no wasted work
+        if (Allure.getLifecycle().getCurrentExecutableKey().isEmpty()) {
+            return;
+        }
 
         final String requestUrl = requestContext.getUri().toString();
         final Object requestBody = requestContext.getEntity();
@@ -87,6 +92,9 @@ public void filter(final ClientRequestContext requestContext) {
     public void filter(final ClientRequestContext requestContext,
                        final ClientResponseContext responseContext)
             throws IOException {
+        if (Allure.getLifecycle().getCurrentExecutableKey().isEmpty()) {
+            return;
+        }
 
         final HttpExchangeResponse.Builder responseBuilder = HttpExchangeResponse.builder()
                 .setStatus(responseContext.getStatus())
diff --git a/allure-jsonunit/src/main/java/io/qameta/allure/jsonunit/JsonPatchMatcher.java b/allure-jsonunit/src/main/java/io/qameta/allure/jsonunit/JsonPatchMatcher.java
@@ -76,6 +76,11 @@ public void _dont_implement_Matcher___instead_extend_BaseMatcher_() {
 
     @Override
     protected void render(final DifferenceListener listener) {
+        // enrichment-only integration: silently skip when no executable is running,
+        // so a disabled Allure reporter produces no warnings and no wasted rendering
+        if (Allure.getLifecycle().getCurrentExecutableKey().isEmpty()) {
+            return;
+        }
         final JsonPatchListener jsonDiffListener = (JsonPatchListener) listener;
         final DiffAttachment attachment = new DiffAttachment(jsonDiffListener.getDiffModel());
         Allure.attachment(
diff --git a/allure-jupiter-assert/src/main/java/io/qameta/allure/jupiterassert/AllureJupiterAssert.java b/allure-jupiter-assert/src/main/java/io/qameta/allure/jupiterassert/AllureJupiterAssert.java
@@ -77,6 +77,11 @@ public void throwable() {
      */
     @Before("anyAssert()")
     public void stepStart(final JoinPoint joinPoint) {
+        // enrichment-only integration: silently skip when no executable is running,
+        // so a disabled Allure reporter produces no warnings and no wasted work
+        if (getLifecycle().getCurrentExecutableKey().isEmpty()) {
+            return;
+        }
         if (joinPoint.getArgs().length > 1) {
             final String assertName = joinPoint.getSignature().getName();
             final String name;
@@ -133,6 +138,9 @@ public void stepStart(final JoinPoint joinPoint) {
      * @param e the e
      */
     public void stepFailed(final Throwable e) {
+        if (getLifecycle().getCurrentExecutableKey().isEmpty()) {
+            return;
+        }
         getLifecycle().updateStep(
                 s -> s
                         .setStatus(getStatus(e).orElse(Status.BROKEN))
@@ -145,6 +153,9 @@ public void stepFailed(final Throwable e) {
      */
     @AfterReturning(pointcut = "anyAssert()")
     public void stepStop() {
+        if (getLifecycle().getCurrentExecutableKey().isEmpty()) {
+            return;
+        }
         getLifecycle().updateStep(s -> s.setStatus(Status.PASSED));
         getLifecycle().stopStep();
     }
diff --git a/allure-okhttp3/src/main/java/io/qameta/allure/okhttp3/AllureOkHttp3.java b/allure-okhttp3/src/main/java/io/qameta/allure/okhttp3/AllureOkHttp3.java
@@ -63,6 +63,11 @@ public AllureOkHttp3 configureHttpExchange(final Consumer<HttpExchange.Builder>
      */
     @Override
     public Response intercept(final Chain chain) throws IOException {
+        // enrichment-only integration: pass the call through untouched when no executable is
+        // running — no warnings, no request/response body buffering
+        if (Allure.getLifecycle().getCurrentExecutableKey().isEmpty()) {
+            return chain.proceed(chain.request());
+        }
         final long start = System.currentTimeMillis();
         final Request request = chain.request();
         final HttpExchangeRequest.Builder requestBuilder = HttpExchangeRequest
diff --git a/allure-okhttp3/src/test/java/io/qameta/allure/okhttp3/AllureOkHttp3Test.java b/allure-okhttp3/src/test/java/io/qameta/allure/okhttp3/AllureOkHttp3Test.java
diff --git a/allure-rest-assured/src/main/java/io/qameta/allure/restassured/AllureRestAssured.java b/allure-rest-assured/src/main/java/io/qameta/allure/restassured/AllureRestAssured.java
diff --git a/allure-spring-web/src/main/java/io/qameta/allure/springweb/AllureRestTemplate.java b/allure-spring-web/src/main/java/io/qameta/allure/springweb/AllureRestTemplate.java
