Skip to content

Commit 1a5ef8b

Browse files
committed
refactor: remove unnecessary skip check in AllureTestNg as test was updated to match TestNG 7 behavior
1 parent bbeb6fd commit 1a5ef8b

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

allure-testng-7/src/main/java/io/qameta/allure/testng7/AllureTestNg.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@ public class AllureTestNg implements
115115
private static final Logger LOGGER = LoggerFactory.getLogger(AllureTestNg.class);
116116

117117
private static final String ALLURE_UUID = "ALLURE_UUID";
118-
private static final String ALLURE_FIXTURE_STARTED = "ALLURE_FIXTURE_STARTED";
119118
private static final List<Class<?>> INJECTED_TYPES = Arrays.asList(
120119
ITestContext.class, ITestResult.class, XmlTest.class, Method.class, Object[].class
121120
);
@@ -470,8 +469,7 @@ public void onTestFailedButWithinSuccessPercentage(final ITestResult result) {
470469
public void beforeInvocation(final IInvokedMethod method, final ITestResult testResult) {
471470
final ITestNGMethod testMethod = method.getTestMethod();
472471
final ITestContext context = testResult.getTestContext();
473-
if (isSupportedConfigurationFixture(testMethod) && testResult.getStatus() != ITestResult.SKIP) {
474-
testResult.setAttribute(ALLURE_FIXTURE_STARTED, true);
472+
if (isSupportedConfigurationFixture(testMethod)) {
475473
ifSuiteFixtureStarted(context.getSuite(), testMethod);
476474
ifTestFixtureStarted(context, testMethod);
477475
ifClassFixtureStarted(testMethod);
@@ -571,8 +569,7 @@ private FixtureResult getFixtureResult(final ITestNGMethod method) {
571569
@Override
572570
public void afterInvocation(final IInvokedMethod method, final ITestResult testResult) {
573571
final ITestNGMethod testMethod = method.getTestMethod();
574-
if (isSupportedConfigurationFixture(testMethod) && testResult.getAttribute(ALLURE_FIXTURE_STARTED) != null) {
575-
testResult.removeAttribute(ALLURE_FIXTURE_STARTED);
572+
if (isSupportedConfigurationFixture(testMethod)) {
576573
final String executableUuid = currentExecutable.get();
577574
currentExecutable.remove();
578575
if (testResult.isSuccess()) {

0 commit comments

Comments
 (0)