review fixes

Author: baev

allure-descriptions-javadoc/src/main/java/io/qameta/allure/description/JavaDocDescriptionRenderer.java

@@ -86,15 +86,11 @@ String render(final String rawDocComment) {
     private String extractDescriptionBody(final String rawDocComment) {
         final String[] lines = normalize(rawDocComment).split("\n", -1);
         final StringBuilder body = new StringBuilder();
-        boolean blockTagStarted = false;
         int inlineTagDepth = 0;
 
         for (String line : lines) {
             if (inlineTagDepth == 0 && startsBlockTag(line)) {
-                blockTagStarted = true;
-            }
-            if (blockTagStarted) {
-                continue;
+                return trimBlankLines(body.toString());
             }
             if (body.length() > 0) {
                 body.append('\n');
@@ -191,6 +187,10 @@ private int renderInlineTag(final String fragment, final int start, final String
             "checkstyle:NPathComplexity",
             "checkstyle:ReturnCount"})
     private int renderHtmlTag(final String fragment, final int start, final StringBuilder rendered) {
+        if (start + 1 >= fragment.length() || Character.isWhitespace(fragment.charAt(start + 1))) {
+            return start;
+        }
+
         final int end = fragment.indexOf('>', start + 1);
         if (end < 0) {
             return start;
@@ -233,15 +233,15 @@ private int renderHtmlTag(final String fragment, final int start, final StringBu
             return end + 1;
         }
         if (CODE_TAG.equals(name)) {
-            if (!closing) {
-                final int closingStart = findClosingTag(fragment, end + 1, CODE_TAG);
-                if (closingStart > end) {
-                    appendCode(rendered, fragment.substring(end + 1, closingStart));
-                    return closingStart + (CLOSING_TAG_PREFIX + CODE_TAG + HTML_TAG_END).length();
-                }
+            if (closing) {
                 return end + 1;
             }
-            return end + 1;
+            final int closingStart = findClosingTag(fragment, end + 1, CODE_TAG);
+            if (closingStart <= end) {
+                return end + 1;
+            }
+            appendCode(rendered, fragment.substring(end + 1, closingStart));
+            return closingStart + (CLOSING_TAG_PREFIX + CODE_TAG + HTML_TAG_END).length();
         }
 
         return end + 1;
@@ -253,14 +253,10 @@ private void appendLink(final StringBuilder rendered, final String payload) {
         }
 
         final int separator = findWhitespace(payload);
-        if (separator < 0) {
-            rendered.append(escapeText(shortenReference(payload)));
-            return;
-        }
-
-        final String label = payload.substring(separator + 1).trim();
+        final String label = separator < 0 ? "" : payload.substring(separator + 1).trim();
         if (label.isEmpty()) {
-            rendered.append(escapeText(shortenReference(payload.substring(0, separator))));
+            final String reference = separator < 0 ? payload : payload.substring(0, separator);
+            rendered.append(escapeText(shortenReference(reference)));
             return;
         }
 

allure-descriptions-javadoc/src/test/java/io/qameta/allure/description/JavaDocDescriptionRendererTest.java

@@ -239,6 +239,14 @@ void shouldIgnoreUnclosedHtmlTagsSafely() {
                 .isEqualTo("Broken bold text");
     }
 
+    @Test
+    void shouldPreserveAngleBracketComparisonsAsText() {
+        final String rendered = renderer.render("Math says a < b > c.");
+
+        assertThat(rendered)
+                .isEqualTo("Math says a &lt; b &gt; c.");
+    }
+
     @Test
     void shouldIgnoreUnmatchedCodeHtmlTagsSafely() {
         final String rendered = renderer.render("Broken <code>value < limit and stray </code>tag");