preserve test failures when stack traces cannot be fully rendered (fixes #1035, via #1335)

Author: baev

allure-java-commons/src/main/java/io/qameta/allure/util/ResultsUtils.java

@@ -870,7 +870,18 @@ private static String getRealThreadName() {
 
     private static String getStackTraceAsString(final Throwable throwable) {
         final StringWriter stringWriter = new StringWriter();
-        throwable.printStackTrace(new PrintWriter(stringWriter));
+        try {
+            throwable.printStackTrace(new PrintWriter(stringWriter));
+        } catch (RuntimeException e) {
+            if (stringWriter.getBuffer().length() == 0) {
+                stringWriter.append(throwable.getClass().getName());
+            }
+            stringWriter
+                    .append(System.lineSeparator())
+                    .append("[Unable to render the complete stack trace: ")
+                    .append(e.getClass().getName())
+                    .append(']');
+        }
         return stringWriter.toString();
     }
 

allure-java-commons/src/test/java/io/qameta/allure/ResultsUtilsTest.java

@@ -27,6 +27,7 @@
 import org.opentest4j.AssertionFailedError;
 import org.opentest4j.ValueWrapper;
 
+import java.io.IOException;
 import java.io.Serializable;
 import java.lang.annotation.Annotation;
 import java.util.List;
@@ -48,6 +49,10 @@
 import static io.qameta.allure.util.ResultsUtils.createTmsLink;
 import static io.qameta.allure.util.ResultsUtils.getLinkTypePatternPropertyName;
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
 @ExtendWith(SystemPropertyExtension.class)
 class ResultsUtilsTest {
 
@@ -399,6 +404,27 @@ void shouldExtractActualAndExpectedFromOpenTest4jAssertionFailedError() {
         assertThat(details.getExpected()).startsWith("expected value (");
     }
 
+    @Test
+    @Issue("1035")
+    void shouldCreateStatusDetailsWhenNestedStackTraceCannotBeRendered() {
+        final RuntimeException cause = mock(RuntimeException.class);
+        when(cause.getSuppressed()).thenReturn(null);
+        final AssertionFailedError error = assertThrows(
+                AssertionFailedError.class,
+                () -> assertThrows(IOException.class, () -> {
+                    throw cause;
+                })
+        );
+
+        final StatusDetails details = getStatusDetailsFor("malformed nested throwable", error);
+
+        assertThat(details.getMessage()).startsWith("Unexpected exception type thrown");
+        assertThat(details.getTrace())
+                .contains(AssertionFailedError.class.getName())
+                .contains("Caused by:")
+                .contains("[Unable to render the complete stack trace: java.lang.NullPointerException]");
+    }
+
     @Test
     void shouldUseOpenTest4jValueWrapperToString() {
         final AssertionFailedError error = new AssertionFailedError(