From bde4f0be88b3ccd1824dc21288833abafce0e49b Mon Sep 17 00:00:00 2001 From: Dmitry Baev Date: Sat, 27 Jun 2026 13:56:25 +0100 Subject: [PATCH 1/2] Verify undocumented allure_test cases do not emit blank descriptions --- crates/allure-cargotest/tests/e2e.rs | 10 +++++++++- smokes/allure-cargotest/tests/descriptions.rs | 6 ++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/crates/allure-cargotest/tests/e2e.rs b/crates/allure-cargotest/tests/e2e.rs index 1e6c2d8..462077d 100644 --- a/crates/allure-cargotest/tests/e2e.rs +++ b/crates/allure-cargotest/tests/e2e.rs @@ -45,7 +45,7 @@ impl Drop for TempProjectDir { #[allure_cargotest::log_asserts] fn generates_allure_results_for_descriptions_sample() { allure::description( - "Verifies the description sample emits explicit descriptions, doc comment descriptions, and doc comment opt-outs.", + "Verifies the description sample emits explicit descriptions, doc comment descriptions, missing-doc omissions, and doc comment opt-outs.", ); let (results, _, _project_dir) = run_sample("descriptions", true); let result = results @@ -74,6 +74,14 @@ fn generates_allure_results_for_descriptions_sample() { ); assert_eq!(json_string(result, "descriptionHtml"), None); + let result = results + .get("leaves_description_absent_without_doc_comment") + .expect("missing leaves_description_absent_without_doc_comment result"); + assert_has_allure_result_fields(result); + assert_eq!(json_string(result, "status"), Some("passed")); + assert_eq!(json_string(result, "description"), None); + assert_eq!(json_string(result, "descriptionHtml"), None); + let result = results .get("skips_doc_comment_description") .expect("missing skips_doc_comment_description result"); diff --git a/smokes/allure-cargotest/tests/descriptions.rs b/smokes/allure-cargotest/tests/descriptions.rs index 12f246a..d913b10 100644 --- a/smokes/allure-cargotest/tests/descriptions.rs +++ b/smokes/allure-cargotest/tests/descriptions.rs @@ -15,6 +15,12 @@ fn uses_doc_comment_as_description() { allure.log_step("doc comment description was applied by the macro"); } +#[allure_test] +#[test] +fn leaves_description_absent_without_doc_comment() { + allure.log_step("no doc comment description was added by the macro"); +} + /// skipped doc comment description #[allure_test(doc = false)] #[test] From f044f0f4cfb231c5fc9a94b5cd0392e9172e0b1e Mon Sep 17 00:00:00 2001 From: Dmitry Baev Date: Sun, 28 Jun 2026 12:47:33 +0100 Subject: [PATCH 2/2] fix build --- smokes/allure-cargotest/Cargo.lock | 6 +++--- smokes/allure-cargotest/expected-fullnames.txt | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/smokes/allure-cargotest/Cargo.lock b/smokes/allure-cargotest/Cargo.lock index f82e596..b123d32 100644 --- a/smokes/allure-cargotest/Cargo.lock +++ b/smokes/allure-cargotest/Cargo.lock @@ -4,7 +4,7 @@ version = 4 [[package]] name = "allure-cargotest" -version = "1.0.2" +version = "1.2.0" dependencies = [ "allure-rust-commons", "allure-test-macros", @@ -20,7 +20,7 @@ dependencies = [ [[package]] name = "allure-rust-commons" -version = "1.0.2" +version = "1.2.0" dependencies = [ "serde", "serde_json", @@ -28,7 +28,7 @@ dependencies = [ [[package]] name = "allure-test-macros" -version = "1.0.2" +version = "1.2.0" [[package]] name = "itoa" diff --git a/smokes/allure-cargotest/expected-fullnames.txt b/smokes/allure-cargotest/expected-fullnames.txt index d1c949f..c28cba2 100644 --- a/smokes/allure-cargotest/expected-fullnames.txt +++ b/smokes/allure-cargotest/expected-fullnames.txt @@ -2,6 +2,7 @@ attachments::writes_attachment concurrent_metadata::metadata_for_first_test_stays_isolated concurrent_metadata::metadata_for_second_test_stays_isolated default_and_global_labels::writes_default_and_global_labels +descriptions::leaves_description_absent_without_doc_comment descriptions::skips_doc_comment_description descriptions::uses_doc_comment_as_description descriptions::writes_descriptions