fix(web-awesome): restore step tree expansion policy logic#680
Merged
Conversation
Accidentally replaced with hardcoded `true` in #676, which caused all steps to be shown regardless of expansion policy, breaking expand_failed_only and collapsed behaviours.
epszaw
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hasFailedStepContext,isOpenByDefaultForPolicy) inTrSteps/index.tsxisRootOpenedByDefaultthat was hardcoded totruein fix(web-awesome): fix group sorting by order/duration; add defaultSortBy option #676, causing steps to always render as expanded regardless of the configured expansion policyRoot cause
In #676, the line:
was replaced with:
This broke
expand_failed_only(passed-only steps were shown) andcollapsed(steps were never collapsed by default).