Fix Add user agent to Curl (#235)

* feat:Add user agent to Curl

* fix: unit test headers

Author: Francois-Gomis

src/Client/Application/ClientConfiguration.php

@@ -30,6 +30,7 @@
 
 class ClientConfiguration
 {
+    const VERSION = '3.0.0';
     private string $apiKey;
     private array $userAgentComponents = [];
     private array $config = [];
@@ -60,6 +61,7 @@ public function __construct(string $apiKey, ?Environment $environment = null, ar
         } catch (InvalidArgumentException $e) {
             $this->addError("Invalid configuration: " . $e->getMessage());
         }
+        $this->initUserAgent();
     }
 
     /**
@@ -216,4 +218,11 @@ public function hasError(): bool {
     public function getErrors(): array {
         return array_values($this->errors);
     }
+
+    private function initUserAgent()
+    {
+        $phpVersion = rtrim(str_replace(PHP_EXTRA_VERSION, '', PHP_VERSION), '-');
+        $this->addUserAgentComponent('PHP', $phpVersion);
+        $this->addUserAgentComponent('Alma for PHP', self::VERSION);
+    }
 }

src/Client/Application/CurlClient.php

@@ -35,7 +35,6 @@
 
 class CurlClient implements ClientInterface
 {
-    const VERSION = '3.0.0';
 
     private ClientConfiguration $config;
 

src/Client/Application/Endpoint/AbstractEndpoint.php

@@ -33,7 +33,9 @@ public function __construct(ClientInterface $client)
      * @return Request The Request object
      */
     private function createRequest(string $method, string $uri, array $body = []): Request {
+
         $headers = [
+            'User-Agent: ' . $this->client->getConfig()->getUserAgentString(),
             'Authorization' => ['Alma-Auth ' . $this->client->getConfig()->getApiKey()]
         ];
         return new Request($method, $uri, $headers, json_encode($body));

tests/Client/Unit/Application/ClientConfigurationTest.php

@@ -10,7 +10,7 @@ class ClientConfigurationTest extends TestCase
 {
     /** @var ClientConfiguration */
     private ClientConfiguration $clientConfig;
-    
+
     public function setUp(): void
     {
         parent::setUp();
@@ -169,6 +169,7 @@ public static function timeoutConfigDataProvider(): array
             ]
         ];
     }
+
     /**
      * @dataProvider timeoutConfigDataProvider
      * @return void
@@ -196,8 +197,10 @@ public function testValidateVerify()
 
     public function testAddUserAgentComponent()
     {
-        $this->clientConfig->addUserAgentComponent('alma-php-sdk', '1.0.0');
-        $this->assertEquals('alma-php-sdk/1.0.0', $this->clientConfig->getUserAgentString());
+        $phpVersion = rtrim(str_replace(PHP_EXTRA_VERSION, '', PHP_VERSION), '-');
+
+        $this->clientConfig->addUserAgentComponent('wc-version', '1.0.0');
+        $this->assertEquals(sprintf('wc-version/1.0.0; Alma for PHP/%s; PHP/%s', ClientConfiguration::VERSION, $phpVersion), $this->clientConfig->getUserAgentString());
     }
 
     /**