fix: remove amount if value 0 for full refund#223
Merged
webaaz merged 5 commits intoDec 5, 2025
Conversation
Francois-Gomis
approved these changes
Dec 4, 2025
joyet-simon
approved these changes
Dec 5, 2025
joyet-simon
approved these changes
Dec 5, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Reason for change
If we send amount 0 in the payload, the refund doesn't make a full refund. To make a full refund we need to send amount: null or remove the amount key in the payload.
This PR remove the amount in the payload if the amount equal 0 to make a full refund.
Linear task
Code changes
We removed the amount in refund DTO if amount === 0 for make a full refund
How to test
As a reviewer, you are encouraged to test the PR locally.
Checklist for authors and reviewers
Non applicable