Skip to content

fix: remove amount if value 0 for full refund#223

Merged
webaaz merged 5 commits into
feature/3.0from
feature/ecom-3553-fix-refund-on-the-order-status-change
Dec 5, 2025
Merged

fix: remove amount if value 0 for full refund#223
webaaz merged 5 commits into
feature/3.0from
feature/ecom-3553-fix-refund-on-the-order-status-change

Conversation

@Benjamin-Freoua-Alma

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma commented Dec 4, 2025

Copy link
Copy Markdown
Member

Reason for change

If we send amount 0 in the payload, the refund doesn't make a full refund. To make a full refund we need to send amount: null or remove the amount key in the payload.
This PR remove the amount in the payload if the amount equal 0 to make a full refund.

Linear task

Code changes

We removed the amount in refund DTO if amount === 0 for make a full refund

How to test

As a reviewer, you are encouraged to test the PR locally.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma requested a review from a team as a code owner December 4, 2025 14:00
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma self-assigned this Dec 4, 2025
@sonarqubecloud

sonarqubecloud Bot commented Dec 5, 2025

Copy link
Copy Markdown

@webaaz webaaz merged commit 43bfe76 into feature/3.0 Dec 5, 2025
4 of 11 checks passed
@webaaz webaaz deleted the feature/ecom-3553-fix-refund-on-the-order-status-change branch December 5, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants