feat: add filterAllowed on FeePlanList#239
Merged
Benjamin-Freoua-Alma merged 3 commits intoApr 16, 2026
Merged
Conversation
Benjamin-Freoua-Alma
approved these changes
Apr 16, 2026
| throw new MerchantEndpointException($e->getMessage(), $request, $response); | ||
| } | ||
| $feePlanList->Add($feePlan); | ||
| $feePlanList->add($feePlan); |
Member
There was a problem hiding this comment.
Split this fix in other PR
Comment on lines
+3
to
+5
| default_language_version: | ||
| python: python3.11 | ||
|
|
Member
There was a problem hiding this comment.
Split this fix in other PR
Benjamin-Freoua-Alma
deleted the
feature/ecom-3867-add-filter-in-feeplanlist-entity-to-get-only-feeplan-allowed
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change
Linear task
We need to get on fee plan allowed from FeePlanList
Code changes
Add function filterAllowed on FeePlanList and unit tests
How to test
As a reviewer, you are encouraged to test the PR locally.
Checklist for authors and reviewers
Non applicable