fix: correct EligibilityQueryDtoTest invalid installments count test#246
Merged
Francois-Gomis merged 2 commits intoMar 31, 2026
Merged
Conversation
Use a truly invalid value (-1) instead of 13 and align expected exception message with the actual DTO validation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Benjamin-Freoua-Alma
approved these changes
Mar 31, 2026
joyet-simon
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update CI PHP matrix from 5.6-8.3 to 7.4-8.4 to match the minimum supported version on this branch
Remove legacy : void workaround for PHP 5.6/7.0
Remove dead ReportPortal configuration step
Add PHP 8.4 to PHPUnit configuration case
Use a truly invalid value (
-1) instead of13intestSetInvalidInstallmentsCountThrowsExceptionAlign
expectExceptionMessagewith the actual DTO message ("Installments count must be positive.")Why
The test was always failing because
13is a valid value (validation only checks<= 0) and the expected exception message didn't match the actual one.Test plan
task 7.4:tests— 252 tests, 519 assertions, all greenFixes ECOM-4025 | Discovered while working on ECOM-4023
🤖 Generated with Claude Code