From a4319333f4e85967247e19aac44dabad2c6a3819 Mon Sep 17 00:00:00 2001
From: Francois-Gomis <francois.gomis@getalma.eu>
Date: Tue, 31 Mar 2026 12:29:01 +0200
Subject: [PATCH 1/2] fix: correct EligibilityQueryDtoTest invalid installments
 count test

Use a truly invalid value (-1) instead of 13 and align expected
exception message with the actual DTO validation.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 tests/Client/Unit/Application/DTO/EligibilityQueryDtoTest.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/Client/Unit/Application/DTO/EligibilityQueryDtoTest.php b/tests/Client/Unit/Application/DTO/EligibilityQueryDtoTest.php
index bc3cbad0..eafd3580 100644
--- a/tests/Client/Unit/Application/DTO/EligibilityQueryDtoTest.php
+++ b/tests/Client/Unit/Application/DTO/EligibilityQueryDtoTest.php
@@ -26,8 +26,8 @@ public function testEligibilityDto()
     public function testSetInvalidInstallmentsCountThrowsException()
     {
         $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage("Installments count must be between 1 and 12.");
-        new EligibilityQueryDto(13);
+        $this->expectExceptionMessage("Installments count must be positive.");
+        new EligibilityQueryDto(-1);
     }
 
     public function testSetNegativeDeferredDaysThrowsException()

From 821c67dca39cfc049dd576f0389251cc7740bd0f Mon Sep 17 00:00:00 2001
From: Francois-Gomis <francois.gomis@getalma.eu>
Date: Tue, 31 Mar 2026 12:40:55 +0200
Subject: [PATCH 2/2] :ci: update PHP matrix to 7.4-8.4 and remove legacy
 workarounds

---
 .github/workflows/ci.yml | 24 ++----------------------
 1 file changed, 2 insertions(+), 22 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 60acd485..064e27a3 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -22,16 +22,12 @@ jobs:
       fail-fast: false
       matrix:
         php:
-          - "5.6"
-          - "7.0"
-          - "7.1"
-          - "7.2"
-          - "7.3"
           - "7.4"
           - "8.0"
           - "8.1"
           - "8.2"
           - "8.3"
+          - "8.4"
 
     steps:
       - name: Checkout repository
@@ -54,26 +50,10 @@ jobs:
       - name: Ensure source code is linted
         run: composer exec phpcs -- src/
 
-      - name: Remove uncompliant statements in legacy code
-        if: contains(fromJson('["5.6", "7.0"]'), matrix.php)
-        run: |
-          # Replace string in files
-          string=': void'
-          grep -r -l "$string" tests/ | xargs sed -i "s/$string//g"
-
-      - name: Set ReportPortal configuration
-        # ReportPortal agent only works for PHP 7.1, 7.2, 7.3 and 7.4
-        if: (github.ref_name == 'main' || github.ref_name == 'develop') && vars.REPORT_PORTAL_ENABLED == 'true' && contains(fromJson('["7.1", "7.2", "7.3", "7.4"]'), matrix.php)
-        run: ./tests/reportportal/reportportal_conf.sh
-        env:
-          REPORT_PORTAL_API_KEY: ${{ secrets.REPORT_PORTAL_API_KEY }}
-          REPORT_PORTAL_ENDPOINT: ${{ vars.REPORT_PORTAL_ENDPOINT }}
-          PHP_VERSION: ${{ matrix.php }}
-
       - name: PHPUnit
         run: |
           case ${{ matrix.php }} in
-            8.1|8.2|8.3 ) composer exec phpunit -- --configuration phpunit.ci.8.xml --coverage-xml ./.coverage;;
+            8.1|8.2|8.3|8.4 ) composer exec phpunit -- --configuration phpunit.ci.8.xml --coverage-xml ./.coverage;;
             *) composer exec phpunit -- --configuration phpunit.ci.xml --coverage-xml ./.coverage;;
           esac
         env: