feat: Fix PHP client to avoid API mode values to silently fallback to…#250
Merged
Benjamin-Freoua-Alma merged 1 commit intoMay 15, 2026
Conversation
Francois-Gomis
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change
Linear task
Especially in a case sensitive context where :
mode = 'live' => Prod
mode = 'Live' => Sandbox
=> We should not have silent fallback.
Either a fallback with a warning : "Unknown value, falling back to sandbox"
or no fallback with an exception thrown.
Code changes
Exception thrown instead of silent fallback — the behavior is explicit.
True as the third parameter of in_array — strict comparison (type + case), which strengthens the detection of cases like 'Live' or 'TEST'.
The
testInvalidModetest: the old assertion checked for a silent fallback to LIVE_MODE. It now tests thatnew Environment('INVALID_MODE')correctly throws anInvalidArgumentExceptionwith the correct message.How to test
As a reviewer, you are encouraged to test the PR locally.
Checklist for authors and reviewers
Non applicable