changed the screen size for iphone 12#194
Open
Uuttssaavv wants to merge 1 commit into
Open
Conversation
|
Duplicate of #193? However that other PR has more changes and I'm not sure which changes are really necessary. Work it out together? |
Author
|
I'd love to work together. The idea is adding some more devices. |
walid-ashik
approved these changes
Oct 15, 2022
Contributor
walid-ashik
left a comment
walid-ashik
left a comment
There was a problem hiding this comment.
LGTM. it should be merged to fix the iPhone 12 screen size issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The correct screen size for iphone 12 is updated as mentioned here https://www.ios-resolution.com/iphone-12/