Add zooming & fix frame sizing#206
Open
westito wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
device_frame: I fixed the size handling of device frames. The specifiedframeSizeand the painted dimensions were twice as big as should be. This is necessary to eliminate scaling. The behaviour can be changed byDeviceFrame(fitContainer)parameter. The default value istrue, so nothing changes to current users. IffitContainerset tofalse, thescreenSizeis used to calculate whole device frame (scales by ratio ofscreenSizeandscreenPath).device_preview: I added a zoom control to the tool panel. Defaults to fit the screen, so nothing changes to current users. When zoom enabled, the device frame is wrapped into aInteractiveViewerwith scaling disabled (scaling handled by zoom control). The device can be moved outside the frame and panning is ignored inside that.