Skip to content

Modernising the entire project#225

Open
bradrushworth wants to merge 26 commits into
aloisdeniel:masterfrom
bradrushworth:master
Open

Modernising the entire project#225
bradrushworth wants to merge 26 commits into
aloisdeniel:masterfrom
bradrushworth:master

Conversation

@bradrushworth
Copy link
Copy Markdown

sdk: '>=2.18.4 <3.0.0'
added new device "Pixel 4" #195
Fix a typo in the documentation #201
Corrects the iPhone 12 screen size and safe area #204
Bump intl to v.0.18.0 #222

@bradrushworth
Copy link
Copy Markdown
Author

Feel free to use this update by adding to your pubspec.yaml

dependency_overrides:
  device_preview:
    git:
      url: https://github.com/bradrushworth/flutter_device_preview.git
      path: device_preview
#    path: ../flutter_device_preview/device_preview
  device_frame:
    git:
      url: https://github.com/bradrushworth/flutter_device_preview.git
      path: device_frame
#    path: ../flutter_device_preview/device_frame

@mikhael28
Copy link
Copy Markdown

This is a sweet update! I hope the author merges it in

@wer-mathurin
Copy link
Copy Markdown

@aloisdeniel: this plugin is awesome, but need some love in terms of accepting PR. PRs that make it compatible with the latest and greatest flutter release and devices seems very helpful. Any timeframe to review this PR?

@Princewil
Copy link
Copy Markdown

Feel free to use this update by adding to your pubspec.yaml

dependency_overrides:
  device_preview:
    git:
      url: https://github.com/bradrushworth/flutter_device_preview.git
      path: device_preview
#    path: ../flutter_device_preview/device_preview
  device_frame:
    git:
      url: https://github.com/bradrushworth/flutter_device_preview.git
      path: device_frame
#    path: ../flutter_device_preview/device_frame

Sorry, I don't get this. I can see two packages here: "device_preview" and "device_frame", you mean I should add both?

@Princewil
Copy link
Copy Markdown

Feel free to use this update by adding to your pubspec.yaml

dependency_overrides:
  device_preview:
    git:
      url: https://github.com/bradrushworth/flutter_device_preview.git
      path: device_preview
#    path: ../flutter_device_preview/device_preview
  device_frame:
    git:
      url: https://github.com/bradrushworth/flutter_device_preview.git
      path: device_frame
#    path: ../flutter_device_preview/device_frame

Sorry, I don't get this. I can see two packages here: "device_preview" and "device_frame", you mean I should add both?

Never mind. I got it now.
Thanks for the update.

@Dnathan33
Copy link
Copy Markdown
Contributor

Thanks for making the updates @bradrushworth. Good work!

@aloisdeniel I'd be happy to help in maintaining the project. I understand that it can be difficult for one person to maintain it all consistently. I'm already familiar with the project's codebase and I have two PRs already merged in.

@walid-ashik
Copy link
Copy Markdown
Contributor

Thanks for making the updates @bradrushworth. Good work!

@aloisdeniel I'd be happy to help in maintaining the project. I understand that it can be difficult for one person to maintain it all consistently. I'm already familiar with the project's codebase and I have two PRs already merged in.

There's no activity in this project. can you fork it and create a separate project where we can all contribute? seems like this project is dead! :(

@yassine-bennkhay
Copy link
Copy Markdown

@bradrushworth Any idea on this issue?
Dialog widget is out of phone boundaries #175

@Nikzed
Copy link
Copy Markdown

Nikzed commented May 31, 2024

iPhone14Pro is not working here. Do not waste your time

This commit updates the SDK constraints and several dependencies in the `pubspec.yaml` files for `device_frame`, `device_preview`, `devtools_device_preview`, and their respective example projects.

Specifically, the SDK constraint has been updated from `'>=2.19.6 <3.0.0'` to `'>=3.9.2 <4.0.0'` or a similar higher version across the projects.

Dependencies like `freezed_annotation`, `freezed`, and `flutter_lints` have also been upgraded to newer versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.