Skip to content

feat: add reusable workflow for pushing images to GAR#15

Merged
sjquant merged 2 commits into
mainfrom
sjquant/workflow-push-gar
Oct 22, 2025
Merged

feat: add reusable workflow for pushing images to GAR#15
sjquant merged 2 commits into
mainfrom
sjquant/workflow-push-gar

Conversation

@sjquant
Copy link
Copy Markdown
Contributor

@sjquant sjquant commented Oct 22, 2025

Changes

  • Google Artifact Registry에 Docker Image를 업로드하기 위한 resusable workflow를 추가합니다.
  • 더이상 사용하지 않는 workflow (notify-teams)를 제거합니다.
  • 의존하는 actions worflow의 버전을 최신화합니다.

Test

  • 아직 테스트를 못해봤는데 다른 레포 하나에 적용해보면서 디버깅할 예정입니다.

Copy link
Copy Markdown
Contributor Author

sjquant commented Oct 22, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sjquant sjquant marked this pull request as ready for review October 22, 2025 07:32
Comment on lines +40 to +46
- name: Authenticate to Google Cloud
id: auth
uses: google-github-actions/auth@v2
with:
workload_identity_provider: ${{ inputs.workload-identity-provider }}
service_account: ${{ inputs.service-account }}
token_format: "access_token"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWS와 달리 OIDC 인증을 활용하여 임시 토큰을 발행하는 방식으로 인증합니다.
(고정 토큰이 필요 없음)

@sjquant sjquant self-assigned this Oct 22, 2025
@sjquant sjquant requested a review from mingi3314 October 22, 2025 07:36
@alphaprime-dev-discord
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@mingi3314 mingi3314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

Comment thread .github/workflows/build-push-gar.yaml Outdated

- name: Authenticate to Google Cloud
id: auth
uses: google-github-actions/auth@v2
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v3가 최신이던데 v2대신 v3를 사용하는 건 어떨까요?

@sjquant sjquant merged commit 64546fe into main Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants