Projection on p-norm ball in Rust#383
Merged
Merged
Conversation
About: - New file ballp.rs: impl of BallP projection - Very basic unit testing - Documentation Issues: - Addresses #333
alphaville
added
enhancement
About: - test projection onto lp-ball using random points on the sphere - introduce rand_distr as a test dependency - unit test of test function that generated random points - test projection when x is inside the ball
About: - testing that p-norm of projection is <= radius - made lp_norm non-public function in BallP
About: - Assert that inner product is < tolerance rather than <0
About: - Unit test with lp-ball centered not at origin - Clippy issues fixed
Cargo fmt set up in VS Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main Changes
Priority
PR #381 should be merged first.
Target version
This PR and #384 will be part of OpEn v0.11.0.
Associated Issues
TODOs
CHANGELOG(s)CHANGELOG,Cargo.tomlandVERSION)