fix(scoring): Use baseScore=100 for Skills Tracking (BUG #4)

PROBLEM:
- Skills Tracking shows Security 18/100 for 4 critical + 4 high issues
- User calculation: 100 - (4×5 + 4×3) = 100 - 32 = 68 ✅
- Actual score: 18/100 ❌

ROOT CAUSE:
- SESSION 13 FIX used baseScore=50 for Skills (neutral baseline)
- This creates confusing UX: 0 issues = 50/100 (looks like failing)
- baseScore=50: 50 - 32 = 18 (matches report but unintuitive)

USER FEEDBACK:
- "4 critical + 4 high should be 68/100, not 18/100"
- baseScore=50 suggests code is mediocre even with 0 issues
- baseScore=100 is more intuitive: starts perfect, deducts for issues

FIX APPLIED (3 locations):
1. v9-grouped-report-formatter.ts wrapper (Skills Tracking display)
2. score-calculator.ts full V9 scoring (Supabase persistence)
3. score-calculator.ts simplified scoring (fallback)

All now use baseScore=100 consistently for Skills:
- 0 issues = 100/100 (perfect) ✅
- 4 critical + 4 high = 68/100 (needs work) ✅
- Intuitive: starts perfect, issues deduct from 100

FILES:
- src/two-branch/analyzers/v9-grouped-report-formatter.ts:1142
- src/two-branch/report/score-calculator.ts:196-205, 458-466

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: alpsla

packages/agents/src/two-branch/analyzers/v9-grouped-report-formatter.ts

@@ -1136,7 +1136,10 @@ export class V9GroupedReportFormatter {
    * All have same weight (only sign differs)
    */
   private calculateCategoryScore(categoryIssues: EnrichedIssue[]): number {
-    return calculateCategoryScore(categoryIssues);
+    // BUG #4 FIX: Skills Tracking should use baseScore=100 (starts perfect, deducts for issues)
+    // This provides better UX: 0 issues = 100/100, not 50/100
+    // User feedback: "4 critical + 4 high should be 68/100, not 18/100"
+    return calculateCategoryScore(categoryIssues, 100);
   }
 
   private _REMOVED_calculateCategoryScore_LEGACY(categoryIssues: EnrichedIssue[]): number {

packages/agents/src/two-branch/report/score-calculator.ts

@@ -193,13 +193,15 @@ export async function calculateFullV9Score(
       codeQuality: calculateCategoryScore(issuesByCategory.codeQuality, 100)
     };
 
-    // SESSION 13 FIX: Calculate category scores for Skill (base=50)
+    // BUG #4 FIX: Calculate category scores for Skill (base=100)
+    // User feedback: baseScore=50 creates confusing UX (0 issues = 50/100 looks like failing)
+    // baseScore=100 is more intuitive: 0 issues = perfect 100/100, issues deduct from there
     const skillCategoryScores = {
-      security: calculateCategoryScore(issuesByCategory.security, 50),
-      performance: calculateCategoryScore(issuesByCategory.performance, 50),
-      architecture: calculateCategoryScore(issuesByCategory.architecture, 50),
-      dependency: calculateCategoryScore(issuesByCategory.dependency, 50),
-      codeQuality: calculateCategoryScore(issuesByCategory.codeQuality, 50)
+      security: calculateCategoryScore(issuesByCategory.security, 100),
+      performance: calculateCategoryScore(issuesByCategory.performance, 100),
+      architecture: calculateCategoryScore(issuesByCategory.architecture, 100),
+      dependency: calculateCategoryScore(issuesByCategory.dependency, 100),
+      codeQuality: calculateCategoryScore(issuesByCategory.codeQuality, 100)
     };
 
     // BUG FIX #44: Calculate APP score (minimum of categories - weakest link)
@@ -453,13 +455,14 @@ export function calculateSimplifiedScore(issues: EnrichedIssue[]): any {
     codeQuality: calculateCategoryScore(issuesByCategory.codeQuality, 100)
   };
 
-  // Calculate skill category scores with base=50 (for Skill Score)
+  // BUG #4 FIX: Calculate skill category scores with base=100 (for Skill Score)
+  // Changed from base=50 to base=100 for better UX (0 issues = 100/100, not 50/100)
   const skillCategoryScores = {
-    security: calculateCategoryScore(issuesByCategory.security, 50),
-    performance: calculateCategoryScore(issuesByCategory.performance, 50),
-    architecture: calculateCategoryScore(issuesByCategory.architecture, 50),
-    dependency: calculateCategoryScore(issuesByCategory.dependency, 50),
-    codeQuality: calculateCategoryScore(issuesByCategory.codeQuality, 50)
+    security: calculateCategoryScore(issuesByCategory.security, 100),
+    performance: calculateCategoryScore(issuesByCategory.performance, 100),
+    architecture: calculateCategoryScore(issuesByCategory.architecture, 100),
+    dependency: calculateCategoryScore(issuesByCategory.dependency, 100),
+    codeQuality: calculateCategoryScore(issuesByCategory.codeQuality, 100)
   };
 
   // APP Score = MIN of all categories (weakest link)