Session 92: Report formatting fixes and test updates

- Fix duplicate Code Quality score display (only show category scores when 2+ categories)
- Fix Time & Cost Analysis to show proper calculation with IDE Autofix context
- Add "Contribute patterns" note for BASIC tier users
- Remove disconnected auto-fixable note and "Copy markdown" tip
- Update test to use Quarkus quickstarts PR #1600 for multi-tool testing

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: alpsla

packages/agents/src/two-branch/analyzers/v9-grouped-report-formatter.ts

@@ -2271,36 +2271,29 @@ ${scoreInterpretation.emoji} **${qualityResult.score.toFixed(1)}/100** (Grade: *
 > ${scoreInterpretation.description}
 
 **Score Breakdown**:
-${qualityResult.categoryScores ? `
-**Category Scores** (Repository Health):
-${byDetectedCategory['Security'] > 0 ? `- 🔒 Security: ${qualityResult.categoryScores.security}/100\n` : ''}${byDetectedCategory['Performance'] > 0 ? `- ⚡ Performance: ${qualityResult.categoryScores.performance}/100\n` : ''}${byDetectedCategory['Architecture'] > 0 ? `- 🏗️  Architecture: ${qualityResult.categoryScores.architecture}/100\n` : ''}${byDetectedCategory['Dependencies'] > 0 ? `- 📦 Dependencies: ${qualityResult.categoryScores.dependency}/100\n` : ''}${byDetectedCategory['Code Quality'] > 0 ? `- ✨ Code Quality: ${qualityResult.categoryScores.codeQuality}/100\n` : ''}
+${qualityResult.categoryScores ? `${(() => {
+          // SESSION 92 FIX: Only show Category Scores when 2+ categories have issues
+          // Avoids redundant display when only Code Quality has issues
+          const categoriesWithIssues = [
+            byDetectedCategory['Security'] > 0,
+            byDetectedCategory['Performance'] > 0,
+            byDetectedCategory['Architecture'] > 0,
+            byDetectedCategory['Dependencies'] > 0,
+            byDetectedCategory['Code Quality'] > 0
+          ].filter(Boolean).length;
+
+          if (categoriesWithIssues >= 2) {
+            return `**Category Scores** (Repository Health):
+${byDetectedCategory['Security'] > 0 ? `- 🔒 Security: ${qualityResult.categoryScores.security}/100\n` : ''}${byDetectedCategory['Performance'] > 0 ? `- ⚡ Performance: ${qualityResult.categoryScores.performance}/100\n` : ''}${byDetectedCategory['Architecture'] > 0 ? `- 🏗️  Architecture: ${qualityResult.categoryScores.architecture}/100\n` : ''}${byDetectedCategory['Dependencies'] > 0 ? `- 📦 Dependencies: ${qualityResult.categoryScores.dependency}/100\n` : ''}${byDetectedCategory['Code Quality'] > 0 ? `- ✨ Code Quality: ${qualityResult.categoryScores.codeQuality}/100\n` : ''}`;
+          }
+          return ''; // Skip category scores when only one category has issues
+        })()}
 **Overall Scores**:
 - 📱 **APP Score**: ${qualityResult.appScore}/100 (MIN of categories - "weakest link")
 - 👨‍💻 **Skill Score**: ${qualityResult.skillScore}/100 (AVG of categories)
 
 > Scores saved to Supabase for tracking trends over time
 
-${(() => {
-          // SESSION 51: Updated to BASIC/PRO tier system
-          // Pattern-based fixes (from Supabase pattern library)
-          const patternFixableGroups = groups.filter(g => this.canAutoFix(g));
-          const patternFixableCount = patternFixableGroups.reduce((sum, g) => sum + g.count, 0);
-          const patternFixablePercent = issues.length > 0 ? Math.round((patternFixableCount / issues.length) * 100) : 0;
-
-          // AI-fixable (PRO tier only - requires AI generation)
-          const aiFixableGroups = groups.filter(g => !this.isSafeToAutoApply(g) && this.canAutoFix(g));
-          const aiFixableCount = aiFixableGroups.reduce((sum, g) => sum + g.count, 0);
-          const aiFixablePercent = issues.length > 0 ? Math.round((aiFixableCount / issues.length) * 100) : 0;
-
-          // Needs guidance (both tiers provide recommendations)
-          const guidanceNeededCount = issues.length - patternFixableCount;
-          const guidanceNeededPercent = issues.length > 0 ? Math.round((guidanceNeededCount / issues.length) * 100) : 0;
-
-          // SESSION 52: Simplified - detailed tier info is in "AI Fix Recommendations" section below
-          return `\n> 🚀 **Fix Coverage**: ${patternFixableCount.toLocaleString()} issues (${patternFixablePercent}%) have pattern-based fixes available
-> See **AI Fix Recommendations** section below for BASIC vs PRO tier details.
-\n`;
-        })()}
 ` : `
 - Base Score: 100.0
 
@@ -7967,9 +7960,7 @@ ${(() => {
 - High: ${issues.filter(i => i.severity === 'high').length}
 - Medium: ${issues.filter(i => i.severity === 'medium').length}
 - Low: ${issues.filter(i => i.severity === 'low').length}
-\`\`\`
-
-> 💡 **Tip**: Copy the markdown above and paste it as a comment on your pull request.`;
+\`\`\``;
   }
 
   /**

packages/agents/src/two-branch/report/business-impact.ts

@@ -518,30 +518,42 @@ function generateBasicTierSection(
   // BASIC tier gets pattern-based fixes but not AI generation
   const patternFixTime = autoFixableCount > 0 ? Math.ceil(autoFixableCount * 0.35 / 60) : 0; // minutes
   const manualReviewTime = totalActiveIssues - autoFixableCount;
-  const basicTimeSaved = baseFixHours * 0.69; // ~69% time reduction with BASIC
+
+  // SESSION 92 FIX: Calculate time savings properly
+  // Time saved only applies when using autofix feature via IDE integration
+  const manualTimePerIssue = 5; // minutes per issue manually
+  const autoFixTimePerIssue = 0.35; // minutes per issue with autofix
+  const estimatedManualHours = (totalActiveIssues * manualTimePerIssue) / 60;
+  const estimatedAutoFixHours = (autoFixableCount * autoFixTimePerIssue) / 60;
+  const manualReviewHours = (manualReviewTime * manualTimePerIssue) / 60;
+  const totalWithBasic = estimatedAutoFixHours + manualReviewHours;
+  const timeSavedPercent = estimatedManualHours > 0 ? Math.round(((estimatedManualHours - totalWithBasic) / estimatedManualHours) * 100) : 0;
 
   return `
 
 ---
 
-### 💼 Time & Cost Analysis
+### 💼 Time & Cost Analysis (with IDE Autofix)
+
+| Metric | Manual Fix | With IDE Autofix |
+|--------|------------|------------------|
+| **Developer Time** | ${estimatedManualHours.toFixed(1)} hours | **${totalWithBasic.toFixed(1)} hours** |
+| **Cost (@$${developerRate}/hr)** | $${Math.round(estimatedManualHours * developerRate).toLocaleString()} | **$${Math.round(totalWithBasic * developerRate).toLocaleString()}** |
+| **Time Reduction** | — | **${timeSavedPercent}%** ✅ |
 
-| Metric | Manual Fix | With CodeQual BASIC |
-|--------|------------|---------------------|
-| **Developer Time** | ${baseFixHours.toFixed(1)} hours | **${(baseFixHours - basicTimeSaved).toFixed(1)} hours** |
-| **Cost (@$${developerRate}/hr)** | $${totalFixCost.toLocaleString()} | **$${Math.round((baseFixHours - basicTimeSaved) * developerRate).toLocaleString()}** |
-| **Time Reduction** | — | **${Math.round((basicTimeSaved / baseFixHours) * 100)}%** ✅ |
+*Time savings based on applying ${autoFixableCount} auto-fixable issues via IDE integration (LSP/SARIF files).*
 
 **What BASIC includes:**
-- ✅ Pattern-based fixes for ${autoFixableCount} issues (~${patternFixTime} min)
+- ✅ Pattern-based fixes for ${autoFixableCount} issues (~${patternFixTime} min via IDE)
 - ✅ AI recommendations for IDE agents (Cursor, Copilot)
 - ✅ Detailed fix guidance for ${manualReviewTime} remaining issues
+- 💡 **Contribute patterns**: When you manually fix issues via IDE, consider contributing the pattern to help others
 
 ---
 
 ### 💡 Upgrade to PRO
 
-**Reduce ${(baseFixHours - basicTimeSaved).toFixed(1)} hours to ~30 seconds**
+**Reduce ${totalWithBasic.toFixed(1)} hours to ~30 seconds** with auto-apply
 
 | Feature | BASIC | PRO |
 |---------|-------|-----|

packages/agents/src/two-branch/report/metadata-footer.ts

@@ -270,11 +270,7 @@ ${blocking.length > 5 ? `\n... and ${blocking.length - 5} more` : ''}` : '### 
 - High: ${issues.filter(i => i.severity === 'high').length}
 - Medium: ${issues.filter(i => i.severity === 'medium').length}
 - Low: ${issues.filter(i => i.severity === 'low').length}
-
-> 💡 **Note**: Auto-fixable count is based on IDE capabilities. See manifest file for exact fixable status per issue.
-\`\`\`
-
-> 💡 **Tip**: Copy the markdown above and paste it as a comment on your pull request.`;
+\`\`\``;
 }
 
 /**

packages/agents/tests/integration/test-v9-lite-e2e.ts

@@ -146,14 +146,14 @@ const TEST_SCENARIOS: TestScenario[] = [
 
   // Uncomment to run Java calibration:
   {
-    name: 'Spring PetClinic PR #950 - Java Pattern Calibration',
-    repoUrl: 'https://github.com/spring-projects/spring-petclinic',
+    name: 'Quarkus Quickstarts PR #1600 - Build Reporter Bump',
+    repoUrl: 'https://github.com/quarkusio/quarkus-quickstarts',
     testMode: 'pr-review',
-    prNumber: 950,
+    prNumber: 1600,  // Quarkus framework - different from Spring
     language: 'java',
-    expectedFramework: 'spring',
+    expectedFramework: 'quarkus',
     expectedToolCount: 5,
-    userTier: (process.env.USER_TIER as 'basic' | 'pro') || 'pro',  // PRO for pattern learning
+    userTier: (process.env.USER_TIER as 'basic' | 'pro') || 'pro',
   },
 
   // ========================================================================
@@ -1169,7 +1169,10 @@ async function runLiteE2ETest(scenario: TestScenario): Promise<void> {
         fixedButNeedsReview: scanFixResult.fixedButNeedsReview?.length || 0,
         durationMs: scanFixResult.durationMs,
         success: scanFixResult.success,
-      } : null
+      } : null,
+
+      // SESSION 92: Pass userTier to formatter for PRO/BASIC tier sections
+      userTier: userTier
     };
 
     const result = await formatter.generateGroupedReport(