Skip to content

Commit eed246b

Browse files
authored
Merge pull request #53 from alpsla/fix/report-quality-4-bugs
fix(report): Apply 5 critical report quality fixes to correct files
2 parents d91b3fb + a44a246 commit eed246b

10 files changed

Lines changed: 67 additions & 2238 deletions

packages/agents/src/two-branch/analyzers/v9-report-formatter.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1532,11 +1532,15 @@ The risk matrix evaluates issues across categories to identify areas of concern.
15321532
/**
15331533
* Get personalized greeting based on context
15341534
*/
1535+
/**
1536+
* Get neutral greeting for reports
1537+
*
1538+
* FIXED: Use neutral "Hi" instead of time-based greeting
1539+
* Rationale: Reports are read at unpredictable times (user may read hours/days later)
1540+
* User feedback: "Good afternoon is wrong when I read it in the morning"
1541+
*/
15351542
private getPersonalizedGreeting(author: string): string {
1536-
const hour = new Date().getHours();
1537-
if (hour < 12) return 'Good morning';
1538-
if (hour < 17) return 'Good afternoon';
1539-
return 'Good evening';
1543+
return 'Hi';
15401544
}
15411545

15421546
/**

packages/agents/src/two-branch/parsers/index.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,4 @@ export { default as TypeScriptToolParser } from './typescript-tool-parser';
2424
export type { TypeScriptIssue, TypeScriptToolResult } from './typescript-tool-parser';
2525

2626
export { default as GoToolParser } from './go-tool-parser';
27-
export type { GoIssue, GoToolResult } from './go-tool-parser';
28-
29-
export { default as JavaToolParser } from './java-tool-parser';
30-
export type { JavaIssue, JavaToolResult } from './java-tool-parser';
27+
export type { GoIssue, GoToolResult } from './go-tool-parser';

0 commit comments

Comments
 (0)