add: Implement a new task for Turkish Thinking datasets#2
Conversation
Summary of ChangesHello @aleynahukmet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new task for Turkish Thinking datasets. The implementation correctly loads and combines two datasets from Hugging Face. The task is set up as a generative task. My review includes a minor code style fix and a point for consideration regarding the evaluation logic, which currently uses a strict exact-match that might be too brittle for a generative reasoning task. Overall, the changes are clear and well-structured.
| row = self.ds[index] | ||
|
|
||
| user_message = row['user'] | ||
| assistant_message = row['assistant'] |
| def evaluate(self, conversation, assistant_response): | ||
| ground_truth = conversation['ground_truth'] | ||
| is_correct = (assistant_response.strip() == ground_truth.strip()) | ||
| return int(is_correct) No newline at end of file |
There was a problem hiding this comment.
The current evaluation uses a strict string comparison between the generated response and the ground truth. For a generative 'Chain of Thought' task, this can be very brittle, as a slightly different (but still correct) phrasing of the reasoning would be marked as incorrect. Have you considered a more flexible evaluation method? For example, if applicable, you could extract the final answer from the reasoning chain and compare that, similar to how the GSM8K task is evaluated. If an exact match is intended, it might be worth adding a comment to explain why.
No description provided.