Merge pull request #28 from altasoft/bugfix/dateonlyXmlSerialization

Add DateOnly support and XML serialization enhancements

Author: temonk

Directory.Build.props

@@ -9,7 +9,7 @@
 	<Product>Domain Primitives</Product>
 	<Company>ALTA Software llc.</Company>
 	<Copyright>Copyright © 2024 ALTA Software llc.</Copyright>
-	<Version>6.0.3</Version>
+	<Version>6.0.4</Version>
   </PropertyGroup>
 
   <PropertyGroup>

src/AltaSoft.DomainPrimitives.Generator/Helpers/MethodGeneratorHelper.cs

@@ -992,6 +992,7 @@ public static void GenerateIXmlSerializableMethods(GeneratorData data, SourceCod
         {
             "string" => "ReadElementContentAsString",
             "bool" => "ReadElementContentAsBoolean",
+            "DateOnly" => "ReadElementContentAsDateOnly",
             _ => $"ReadElementContentAs<{data.PrimitiveTypeFriendlyName}>"
         };
 

src/AltaSoft.DomainPrimitives/XmlReaderExt.cs

@@ -13,13 +13,33 @@ namespace AltaSoft.DomainPrimitives;
 public static class XmlReaderExt
 {
     /// <summary>
-    /// Reads the content of the current element as a <see cref="byte" /> object.
+    /// Reads the content of the current XML element as a <typeparamref name="T"/> value.
     /// </summary>
-    /// <param name="reader">The XmlReader instance.</param>
-    /// <returns>A byte object representing the value read from the element.</returns>
+    /// <typeparam name="T">The type of value to parse, which must implement <see cref="IParsable{TSelf}"/>.</typeparam>
+    /// <param name="reader">The <see cref="XmlReader"/> instance.</param>
+    /// <returns>
+    /// A <typeparamref name="T"/> value parsed from the current element's content.
+    /// </returns>
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public static T ReadElementContentAs<T>(this XmlReader reader) where T : IParsable<T>
     {
         return T.Parse(reader.ReadElementContentAsString(), CultureInfo.InvariantCulture);
     }
+
+    /// <summary>
+    /// Reads the content of the current XML element as a <see cref="DateOnly"/> value.
+    /// </summary>
+    /// <param name="reader">The <see cref="XmlReader"/> instance.</param>
+    /// <returns>
+    /// A <see cref="DateOnly"/> value parsed from the current element's content.
+    /// </returns>
+    [MethodImpl(MethodImplOptions.AggressiveInlining)]
+    public static DateOnly ReadElementContentAsDateOnly(this XmlReader reader)
+    {
+        var str = reader.ReadElementContentAsString();
+        if (DateOnly.TryParse(str, CultureInfo.InvariantCulture, out var result))
+            return result;
+
+        return DateOnly.FromDateTime(DateTime.Parse(str, CultureInfo.InvariantCulture));
+    }
 }

tests/AltaSoft.DomainPrimitives.Generator.Tests/DomainPrimitiveGeneratorTest.cs

@@ -829,6 +829,44 @@ public static PrimitiveValidationResult Validate(uint value)
             GenerateTypeConverters = false
         });
     }
+
+    [Fact]
+    public Task DateOnlyValue_GeneratesAllInterfacesAndConvertersWithXml()
+    {
+        const string source = """
+                              using System;
+                              using System.Collections.Generic;
+                              using System.Linq;
+                              using System.Text;
+                              using System.Threading.Tasks;
+                              using AltaSoft.DomainPrimitives;
+
+                              namespace AltaSoft.DomainPrimitives;
+
+                              public readonly partial struct DateOnlyXmlValue : IDomainValue<DateOnly>
+                              {
+                              	/// <inheritdoc/>
+                              	public static PrimitiveValidationResult Validate(DateOnly value)
+                              	{
+                              		if (value == default)
+                              			return "Invalid Value";
+
+                              		return PrimitiveValidationResult.Ok;
+                              	}
+                              }
+
+                              """;
+
+        return TestHelper.Verify(source, (_, x, _) => Assert.Equal(1, x.Count), new DomainPrimitiveGlobalOptions()
+        {
+            GenerateEntityFrameworkCoreValueConverters = false,
+            GenerateJsonConverters = false,
+            GenerateSwaggerConverters = false,
+            GenerateTypeConverters = false,
+            GenerateXmlSerialization = true
+        });
+    }
+
     public static class TestHelper
     {
         internal static Task Verify(string source, Action<ImmutableArray<Diagnostic>, List<string>, GeneratorDriver>? additionalChecks = null, DomainPrimitiveGlobalOptions? options = null)

tests/AltaSoft.DomainPrimitives.Generator.Tests/ModuleInitializer.cs

@@ -1,4 +1,5 @@
 using System.Runtime.CompilerServices;
+using DiffEngine;
 
 namespace AltaSoft.DomainPrimitives.Generator.Tests;
 
@@ -8,6 +9,6 @@ public static class ModuleInitializer
     public static void Init()
     {
         VerifySourceGenerators.Initialize();
-
+        DiffTools.UseOrder(DiffTool.VisualStudioCode);
     }
 }